Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top offers component #3514

Closed
Tracked by #660 ...
yangwao opened this issue Jul 21, 2022 · 9 comments
Closed
Tracked by #660 ...

Top offers component #3514

yangwao opened this issue Jul 21, 2022 · 9 comments
Labels
$ ~<50usd A-basilisk issues related to basilisk parachain A-subsquid indexer issues to subsquid p3 non-core, affecting less than 40%

Comments

@yangwao
Copy link
Member

yangwao commented Jul 21, 2022

We would need component which would show NFTs with most offers.

Table columns should be sortable and be like

  • Collection, Item, Total number of offers, Total amount of offers, Date of newest/last offer
  • By default, sorted by the total amount of offers

For example this NFT,
https://beta.kodadot.xyz/bsx/gallery/1380208565-1
the single row would look like
image

| Spodee | Spoodee | 3 | 345 567 BSX | 1 day |

It can look like current offers at https://beta.kodadot.xyz/bsx/stats

  • route could be /topoffers
  • put links to /topoffers into dropdown from Stats in navbar
@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app A-basilisk issues related to basilisk parachain A-subsquid indexer issues to subsquid p3 non-core, affecting less than 40% and removed p2 core functionality, or is affecting 60% of app labels Jul 21, 2022
@zhengow
Copy link
Contributor

zhengow commented Jul 21, 2022

I would like to use this query to filter nfts which has no offer:

query MyQuery {
  nftEntities(where: {offers_some: {}}) {
    offers {
      id
      createdAt
      updatedAt
      price
    }
    collection {
      name
    }
    name
  }
}

image

How do you think?

@prachi00 prachi00 self-assigned this Jul 27, 2022
@kodabot
Copy link
Collaborator

kodabot commented Jul 27, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Thursday, July 28th 2022, 13:15:06 UTC -> 36 hours

@roiLeo
Copy link
Contributor

roiLeo commented Jul 27, 2022

I would like to use this query to filter nfts which has no offer:

query MyQuery {
  nftEntities(where: {offers_some: {}}) {
    offers {
      id
      createdAt
      updatedAt
      price
    }
    collection {
      name
    }
    name
  }
}

How do you think?

This query will be greedy without limit

@kodabot
Copy link
Collaborator

kodabot commented Jul 28, 2022

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@petersopko petersopko mentioned this issue Jul 29, 2022
89 tasks
@zhengow
Copy link
Contributor

zhengow commented Jul 30, 2022

I would like to use this query to filter nfts which has no offer:

query MyQuery {
  nftEntities(where: {offers_some: {}}) {
    offers {
      id
      createdAt
      updatedAt
      price
    }
    collection {
      name
    }
    name
  }
}

How do you think?

This query will be greedy without limit

So it is need to write a resolver right?

@yangwao
Copy link
Member Author

yangwao commented Aug 3, 2022

Any progress on this @zhengow 👀

@zhengow
Copy link
Contributor

zhengow commented Aug 3, 2022

Any progress on this @zhengow 👀

I'd like to wait until kodadot/snek#42 to be merged. 👀
Thus, I will know how to contribute to subsquid.

@vikiival
Copy link
Member

vikiival commented Aug 3, 2022

This query will be greedy without limit

yup I would close this without limit :) kodadot/rubick#109

@zhengow
Copy link
Contributor

zhengow commented Aug 12, 2022

kodadot/snek#45
Waiting for review.

@yangwao yangwao added p1 preventing everyone from using app p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% p1 preventing everyone from using app labels Aug 16, 2022
@yangwao yangwao added p3 non-core, affecting less than 40% and removed p2 core functionality, or is affecting 60% of app labels Jan 24, 2023
@roiLeo roiLeo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-basilisk issues related to basilisk parachain A-subsquid indexer issues to subsquid p3 non-core, affecting less than 40%
Projects
Status: No status
Development

No branches or pull requests

6 participants