Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make white background as toggle everywhere #3713

Closed
yangwao opened this issue Aug 11, 2022 · 17 comments · Fixed by #3742
Closed

Make white background as toggle everywhere #3713

yangwao opened this issue Aug 11, 2022 · 17 comments · Fixed by #3742
Labels
$ ~<50usd p1 preventing everyone from using app

Comments

@yangwao
Copy link
Member

yangwao commented Aug 11, 2022

You can start from #2947 (once is merged),
let's make the default white background everywhere

Please check

  • explorer
  • series
  • Check do any other tables
  • click through the whole app where is black background and change it to a white one

Currently known black bg

Action

image

Basilisk Stats

image

Spotlight (RMRK)

image

Series (RMRK)

image

Sales (RMRK)

image

Hot (RMRK)

image

Wallet chooser

image

Create Classic Collection (RMRK,BSX)

image

Simple mint (RMRK)

image

Create Classic NFT (BSX) description

image

Footer

image

Incoming Offers

image

I might miss some, so feel free to recheck and change it to white

@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app S-blocked-✋ labels Aug 11, 2022
@yangwao yangwao mentioned this issue Aug 11, 2022
10 tasks
@yangwao yangwao added p1 preventing everyone from using app and removed S-blocked-✋ p2 core functionality, or is affecting 60% of app labels Aug 11, 2022
@vikiival
Copy link
Member

image

@prachi00
Copy link
Member

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Saturday, August 13th 2022, 04:56:34 UTC -> 36 hours

@prachi00
Copy link
Member

@yangwao just to confirm, are we like going to provide a toggle to switch back to dark (night mode) ?

@vikiival
Copy link
Member

From the description

You can start from #2947 (once is merged),
let's make the default white background everywhere

the switch is already there ;)

@petersopko
Copy link
Contributor

petersopko commented Aug 12, 2022

loading looks like this during mint looks like this

image

@petersopko
Copy link
Contributor

item actions detail:

image

@petersopko
Copy link
Contributor

petersopko commented Aug 12, 2022

teleport:

image

@petersopko
Copy link
Contributor

petersopko commented Aug 12, 2022

admin:

image

@petersopko
Copy link
Contributor

transfer:

image

@kodabot
Copy link
Collaborator

kodabot commented Aug 13, 2022

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@yangwao yangwao changed the title Make white background as default everywhere Make white background as toggle everywhere Aug 15, 2022
@petersopko
Copy link
Contributor

when browsing gallery / collections, this popup which appears on hover is way too dark:

image

@prachi00
Copy link
Member

I am working on this one

@prachi00
Copy link
Member

@petersopko @yangwao half of the things mentioned here seems to have been solved already

prachi00 added a commit that referenced this issue Aug 16, 2022
@prachi00
Copy link
Member

Screen Shot 2022-08-15 at 9 30 32 PM

for this, can we use svg instead?

@petersopko
Copy link
Contributor

Screen Shot 2022-08-15 at 9 30 32 PM

for this, can we use svg instead?

what am I looking at?

@vikiival
Copy link
Member

for this, can we use svg instead?

Or .wepb with transparent background? :) svg would be too big.

what am I looking at?

You are looking at placeholder.webp

yangwao added a commit that referenced this issue Aug 18, 2022
@yangwao yangwao mentioned this issue Aug 24, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd p1 preventing everyone from using app
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants