Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet connect dialog v2 #4405

Closed
exezbcz opened this issue Nov 24, 2022 · 10 comments · Fixed by #4828
Closed

Wallet connect dialog v2 #4405

exezbcz opened this issue Nov 24, 2022 · 10 comments · Fixed by #4828
Assignees
Labels
A-wallet related to wallet stuff p2 core functionality, or is affecting 60% of app redesign

Comments

@exezbcz
Copy link
Member

exezbcz commented Nov 24, 2022

connected with:

Basics

landing page - main (2)

  • this is how it will look like when you open the sidebar on
  • darker screen, black bg with 17% opacity
  • I experienced with background blur but its not that usable when then displaying wallet.

Phases

warning

  • confirmation
    image
  • primary button there

Connect wallet

Wallet providers as dropdowns, you can only see wallet you have downloaded.
Other wallet are hidden under "more option"

  • these wallets have icon next to it co it indicates you can download them.

At the bottom there is dialog with introducing into wallets and link to a educational video in case you are a beginner.
Connect wallet-hover1 (2)

Wallet

  • we are moving it to the sidebar
    Connect wallet-hover1 (1)

hover states

wallet provider:

  • same as the search results, when you hover over, the background turns into k-accentlight2 (lighter version than k-accentlight), in dark mode its k-accentlight2dark
    image

sub-select:

  • when you click the chevron turns down and reveals your accounts.
  • there is a name and short adress
  • next to the icon there is line, like in vscode etc. (its clear that its sub section)
  • the line is only big as the max height of the content
  • hover effect starts at the line but is slightly bigger vertically, should have same size as the wallet provider hovers.
  • there are different screens that show it.
    this shows the hover on account:
    image

More options:
default state is k-grey, when hovering it turns into k-black

  • when clicking it displays the other options/wallets you can download

Cross icon:
turn into k-hovergrey, in case of darkmode its k-shade.

there is a close button at the top right in every sidebar + a clickable button (with left chevron) you can use to close it as well.
image

Mobile

on mobile the wallet section in menu stays the same. We wont change it.
We are going to change only the connect part.
It will popup over the whole page - it should be a overlay so once you close it you stay where you had been last time.

Darkmode

pretty straightforward, hover on the bigger areas have k-accentlightdark instead of the k-accentlight2.
If you have any questions about the dark mode feel free to ping.

Figma

designs are now available in gallery item handoff.
image
https://www.figma.com/file/gHSzqGPeQ9qK4L0qIDcTjY/gallery-item-handoff?node-id=1270%3A5615&t=s0dzfVDc0DFz66R4-1

Thanks!

@exezbcz exezbcz added design-request p4 affecting less than 10% of app labels Nov 24, 2022
@yangwao yangwao added A-wallet related to wallet stuff redesign labels Dec 4, 2022
@yangwao yangwao added p3 non-core, affecting less than 40% and removed p4 affecting less than 10% of app labels Jan 2, 2023
@yangwao
Copy link
Member

yangwao commented Jan 3, 2023

@exezbcz will soon drop the hand-off file for this, and we can start work on this 💪

@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Jan 3, 2023
@prachi00
Copy link
Member

prachi00 commented Jan 4, 2023

is this only for mobile?

@exezbcz
Copy link
Member Author

exezbcz commented Jan 4, 2023

is this only for mobile?

Nope

@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

I guess time for @exezbcz to make issue with design and description this week so we can start working on this for next release

@exezbcz
Copy link
Member Author

exezbcz commented Jan 20, 2023

updated ✔️

@yangwao
Copy link
Member

yangwao commented Jan 24, 2023

@Jarsen136 let's take this one

@Jarsen136
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Jan 24, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Wednesday, January 25th 2023, 22:31:07 UTC -> 36 hours

@Jarsen136
Copy link
Contributor

Jarsen136 commented Jan 25, 2023

At the bottom there is dialog with introducing into wallets and link to a educational video in case you are a beginner.

image

I wonder which URL should we open when clicking this one. 👀 @yangwao

@yangwao
Copy link
Member

yangwao commented Jan 26, 2023

oh, seems onboarding materials are missing

I found only this available on docs https://docs.kodadot.xyz/tutorials/how-to-kodadot-phone-ios.html#what-we-need

oh ok, probably we can put it this one there https://docs.kodadot.xyz/tutorial-overview.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wallet related to wallet stuff p2 core functionality, or is affecting 60% of app redesign
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants