Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4125 mobile navbar #4483

Merged
merged 10 commits into from
Dec 16, 2022
Merged

#4125 mobile navbar #4483

merged 10 commits into from
Dec 16, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Dec 13, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-12-12 at 7 18 10 PM

@prachi00 prachi00 requested a review from a team as a code owner December 13, 2022 03:18
@prachi00 prachi00 requested review from preschian and removed request for a team December 13, 2022 03:18
@kodabot
Copy link
Collaborator

kodabot commented Dec 13, 2022

WARNING @prachi00 PR for issue #4125 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4125

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 51c4eeb
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/639be70f1a3d52000884c944
😎 Deploy Preview https://deploy-preview-4483--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00
Copy link
Member Author

@yangwao @preschian worked on top of the previous PR that was raised
I shifted the components to use vue compostion and cleaned up the css and the logic a little bit

@prachi00 prachi00 changed the title Feat nav mob #4125 mobile navbar Dec 13, 2022
@yangwao
Copy link
Member

yangwao commented Dec 13, 2022

while logged in
image

lines should be full from left to right.
image

image

image

image

I guess you plan work on it :)
putting back to draft till it's ready for testing

@yangwao yangwao marked this pull request as draft December 13, 2022 15:20
@yangwao
Copy link
Member

yangwao commented Dec 13, 2022

oh edit, on mobile view on desktop chrome it seems ok!
image

seems there is an issue with mobile device detection then?

seems to happen only if there is "mobile" is not enabled.
that's super strange 😅

image

@yangwao yangwao marked this pull request as ready for review December 13, 2022 15:24
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to fix deepscan and deepsource issues. and follow vue best practices for props https://v2.vuejs.org/v2/style-guide/?redirect=true#Prop-definitions-essential

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search bar section empty
image

components/navbar/MobileLanguageOption.vue Outdated Show resolved Hide resolved
components/navbar/NavbarExploreOptions.vue Outdated Show resolved Hide resolved
components/Navbar.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
@prachi00
Copy link
Member Author

@exezbcz how exactly the search on mobile should look? I cant find the designs for that

@exezbcz
Copy link
Member

exezbcz commented Dec 15, 2022

@exezbcz how exactly the search on mobile should look? I cant find the designs for that

okay, so we are going to keep the version that is currently on beta.kodadot.xyz with few changes.

  • Stretch the search results to 100% vw, so there is no gap. We can do that because we finally have the close button when you focus on searchbar.

image

like this:
image

  • while keeping the margin left and right. To be exact - 20px

Is this okay?

@codeclimate
Copy link

codeclimate bot commented Dec 15, 2022

Code Climate has analyzed commit 9d4321a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

This can be fixed in the follow-up issue as it's for the non-mobile devices but on 600px width

image

I guess we will make follow-up issue on this one
On 600px width non-mobile I see this

image
image

Address select dialogue
but I guess that's going to be resolved in #4405
image

@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

pay 80 usd
we will make follow-up issue

@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

😍 Perfect, I’ve sent the payout
💵 $80 @ 26.81 USD/KSM ~ 2.984 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x8c82d3aadeb3beb9db2c2e6135b81068f9df3a20b8f08ed91f009cd49d5b36cd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 16, 2022
@yangwao yangwao merged commit ec773dd into main Dec 16, 2022
@yangwao yangwao deleted the feat-nav-mob branch December 16, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redesign neobrutalism of navbarV2 on mobile
7 participants