Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Durable object cache #4597

Closed
vikiival opened this issue Jan 4, 2023 · 3 comments · Fixed by #4637
Closed

Remove Durable object cache #4597

vikiival opened this issue Jan 4, 2023 · 3 comments · Fixed by #4637
Labels
$ ~<50usd enhancement New feature or request p2 core functionality, or is affecting 60% of app

Comments

@vikiival
Copy link
Member

vikiival commented Jan 4, 2023 •
edited by yangwao
Loading

Is your feature request related to a problem?

Currently we integrated our custom IPFS gateway for IPFS images and therefore we do not need Durable object for cache.

To spot usage of Durable object look for

const imageLinks = await getCloudflareImageLinks(metadataList)

Describe the solution you would like

Remove code related to the cloudflare durable objects.

Describe alternatives you have considered

also open issue what could refactored.

Screenshots

No response

Are there opened related issues?

No response

Ref
@vikiival vikiival added enhancement New feature or request $ ~<50usd p2 core functionality, or is affecting 60% of app labels Jan 4, 2023
@yangwao yangwao mentioned this issue Jan 4, 2023
Closed
This was referenced Jan 6, 2023
Closed
Merged
@yangwao yangwao closed this as completed Jan 6, 2023
@vikiival vikiival mentioned this issue Jan 6, 2023
Open
@vikiival
Copy link
Member Author

vikiival commented Jan 6, 2023

@yangwao can I deprecate the worker?

@yangwao
Copy link
Member

yangwao commented Jan 7, 2023

Thank you for your amazing and quick response! @holopin-bot @vikiival

@yangwao
Copy link
Member

yangwao commented Jan 7, 2023

@yangwao can I deprecate the worker?

yup, seems it's gone anyway? @vikiival

@vikiival vikiival mentioned this issue Jan 7, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd enhancement New feature or request p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

👋 Good bye Durable Object kodadot/nft-gallery
2 participants
@yangwao @vikiival