Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS gateway by KodaDot <3 #4596

Merged
merged 8 commits into from
Jan 4, 2023
Merged

IPFS gateway by KodaDot <3 #4596

merged 8 commits into from
Jan 4, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jan 4, 2023

  • πŸ”§ domain for images
  • ⚑ sanitizer uses cloudflare images

Thank you for your contribution to the KodaDot NFT gallery.

πŸ‘‡ _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests πŸ§ͺ
  • I've found edge cases

Screenshot πŸ“Έ

@vikiival vikiival requested a review from a team as a code owner January 4, 2023 13:15
@vikiival vikiival requested review from preschian and removed request for a team January 4, 2023 13:15
@vikiival vikiival self-assigned this Jan 4, 2023
@netlify
Copy link

netlify bot commented Jan 4, 2023

βœ… Deploy Preview for koda-nuxt ready!

Name Link
πŸ”¨ Latest commit 5b3ced1
πŸ” Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63b58cb59639dd00092ae79e
😎 Deploy Preview https://deploy-preview-4596--koda-nuxt.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vikiival
Copy link
Member Author

vikiival commented Jan 4, 2023

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

image.kodadot.workers.dev/ipfs/bafkreieu5u3zm232hnwyevfqqerxy637augicgtkhsyg3d5xugkstby47u

seems the custom domain works

https://image.w.kodadot.xyz/ipfs/bafkreieu5u3zm232hnwyevfqqerxy637augicgtkhsyg3d5xugkstby47u

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

Seems that one collection doesn't work?
βœ… - https://deploy-preview-4596--koda-nuxt.netlify.app/rmrk/collection/2644199cf3652aaa78-KK01?page=1
image

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

@vikiival πŸ‘€

image

@preschian
Copy link
Member

@vikiival seems doesn't work?
deploy-preview-4596--koda-nuxt.netlify.app/bsx/collection/1000011

image on this page still hit pinata

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

I guess we still need to migrate some pictures to cf-images before merging this?

@vikiival
Copy link
Member Author

vikiival commented Jan 4, 2023

@vikiival seems doesn't work?
deploy-preview-4596--koda-nuxt.netlify.app/bsx/collection/1000011

image on this page still hit pinata

was fixed imo in b3eddf5

@yangwao yangwao mentioned this pull request Jan 4, 2023
18 tasks
@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

Viki is planning bad commit πŸ‘€

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

components/rmrk/utils.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jan 4, 2023

Code Climate has analyzed commit 5b3ced1 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

Works so far, made few follow up

@yangwao yangwao merged commit 01766f6 into main Jan 4, 2023
@yangwao yangwao deleted the koda-images branch January 4, 2023 14:32
@preschian preschian mentioned this pull request Jan 4, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reworking media serving for edge caching, speed and costs
3 participants