Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail pictures in links not working on Twitter again #5268

Closed
JustLuuuu opened this issue Mar 14, 2023 · 9 comments
Closed

Thumbnail pictures in links not working on Twitter again #5268

JustLuuuu opened this issue Mar 14, 2023 · 9 comments
Labels
$$ ~51-150usd A-seo-search-socials A-twitter something going on related with twitter bug Something isn't working p1 preventing everyone from using app

Comments

@JustLuuuu
Copy link
Member

JustLuuuu commented Mar 14, 2023

What happened?

I wanted to share this NFT on Twitter: https://kodadot.xyz/rmrk/gallery/16967859-62DB09E2F7FAA81C5F-FLOW-NIGHT_MAGIC_SPELLS-0000000000000001

It looks like this: RMRK
Screenshot 2023-03-14 at 12 54 30

I checked older posts and here is one from Deepologic: Basilisk
Screenshot 2023-03-14 at 12 56 50

It looks bad, can we fix it?

Please reproduce in steps

Copying url and pasting it on twitter

Expected Behavior

Add image to post

@JustLuuuu JustLuuuu added the bug Something isn't working label Mar 14, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Mar 14, 2023

duplicate #4058 and #2136

note: works on beta

@roiLeo
Copy link
Contributor

roiLeo commented Mar 16, 2023

Reopened since it doesn't work anymore on beta
Tested on: https://beta.kodadot.xyz/rmrk/gallery/16967859-62DB09E2F7FAA81C5F-FLOW-NIGHT_MAGIC_SPELLS-0000000000000001

Screenshot 2023-03-16 at 10-16-09 OpenGraph - Preview Social Media Share and Generate Metatags

(works with seo inspector?)
Capture d’écran 2023-03-16 à 10 17 41 AM

@roiLeo roiLeo reopened this Mar 16, 2023
@roiLeo roiLeo added p2 core functionality, or is affecting 60% of app A-seo-search-socials A-twitter something going on related with twitter labels Mar 16, 2023
@yangwao
Copy link
Member

yangwao commented Mar 17, 2023

image

I thought we already replaced this stuff? og-image-green-seven

@roiLeo
Copy link
Contributor

roiLeo commented Mar 21, 2023

I thought we already replaced this stuff? og-image-green-seven

we still use https://github.com/AndreyGrin/og-image

@yangwao
Copy link
Member

yangwao commented Mar 21, 2023

@yangwao yangwao added p1 preventing everyone from using app $$ ~51-150usd and removed p2 core functionality, or is affecting 60% of app labels Mar 21, 2023
@preschian
Copy link
Member

preschian commented Mar 22, 2023

Reopened since it doesn't work anymore on beta

seems like prerender on netlify not working anymore

hey seems doesnt work on production either

yes, if the beta didn't work, the production would also not work. because on production we use beta (netlify-prerender) as a proxy https://github.com/kodadot/workers/blob/main/prerender-opengraph/src/netlify.ts#L9

afaik, prerender/SPA/client-side method can't be tested with https://www.opengraph.xyz/
it's better to use https://developers.facebook.com/tools/debug/

but, since yesterday, I'm starting to experiment with ssr-opengraph. so, with the ssr method, we can test it on https://www.opengraph.xyz/

I'm still testing it for the gallery item
demo:

@preschian
Copy link
Member

preschian commented Mar 29, 2023

hi @JustLuuuu, could you check again? and give me the Twitter link to your status and deepologic?

btw, we can refresh opengraph preview on Facebook with this button on https://developers.facebook.com/tools/debug/
Screenshot 2023-03-29 at 10 54 36

unfortunately, I don't know how to refresh it on Twitter. ref:

currently should be working on bsx/ksm/snek. and can be tested in opengraph.xyz

@JustLuuuu
Copy link
Member Author

hi @JustLuuuu, could you check again? and give me the Twitter link to your status and deepologic?

My status: https://twitter.com/Just_Luuuu/status/1635610269089947648
Screenshot 2023-03-29 at 12 13 09

Deeplogics: https://twitter.com/deepologic/status/1636769561763790848 - not working
Screenshot 2023-03-29 at 12 23 25

I found this on one of his new posts: https://twitter.com/deepologic/status/1639898400974946309 - looks like its working
https://twitter.com/deepologic/status/1627685832847986691 - working

Looks like this is almost working for now.

@preschian
Copy link
Member

My status: twitter.com/Just_Luuuu/status/1635610269089947648

looks like it working now

Screenshot 2023-03-30 120452

Deeplogics: twitter.com/deepologic/status/1636769561763790848 - not working

I guess that Deepologic accidentally clicked (x) button when tweeting that status. it will hide the thumbnail pictures on the tweet

Screenshot 2023-03-30 120706

Looks like this is almost working for now.

let's close this then. please reopen this issue if happen again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-seo-search-socials A-twitter something going on related with twitter bug Something isn't working p1 preventing everyone from using app
Projects
None yet
Development

No branches or pull requests

4 participants