feat: init ssr-opengraph #41

preschian · 2023-03-22T16:19:49Z

related kodadot/nft-gallery#5268

the method is quite similar

if the request is coming from a non-bot https://github.com/kodadot/workers/pull/41/files#diff-1860af2eaf6e2c14cc185436d808d762199ab1e9ec51fd94afe805d52bf8570eR18 it will continue the request
if the request is coming from a crawler (bot) it will fetch data to subsquid and then render static html https://github.com/kodadot/workers/pull/41/files#diff-1860af2eaf6e2c14cc185436d808d762199ab1e9ec51fd94afe805d52bf8570eR54

todo:

collection detail
rmrk2
put rmrk to @kodadot1/static?

step to deploy:

after merging this PR, make sure to deploy the prerender-opengraph worker first
and then deploy ssr-opengraph. to avoid routes conflict https://github.com/kodadot/workers/pull/41/files#diff-50d1a6082b03f808cc776ab435488ebf63e81e82829e73e9fc76d094f2d5199aR4

additional notes:

seems like prerender on netlify not working anymore. so, it will works on kodadot.xyz only

preschian · 2023-03-22T16:27:55Z

cc @yangwao @vikiival @roiLeo

vikiival

please use uniquery and minipfs

vikiival · 2023-03-22T17:37:43Z

https://github.com/poppyseedDev/polkadot-fandom-page/blob/main/src/helper/index.ts

vikiival · 2023-03-22T17:42:46Z

for the uniquery

https://github.com/poppyseedDev/polkadot-fandom-page/blob/8274132d79f42967e992710951b27bd61dd111ac/src/pages/products/%5Bproduct%5D.tsx#LL26C9-L26C82

vikiival

Really good job, small things

vikiival · 2023-03-23T08:51:11Z

ssr-opengraph/src/utils.ts

+// TODO: put 'rmrk' into Prefix type
+export type Chain = 'rmrk' & Prefix;
+
+export const endpoints: Record<Chain, string> = {


This can be imported also from static

I suggest keeping it as it is. once we add rmrk in static/types, we can import all endpoints from static https://github.com/kodadot/packages/blob/main/static/src/types.ts#L1

vikiival · 2023-03-23T08:56:00Z

ssr-opengraph/src/utils.ts

+};
+
+export const getNftById = async (chain: Chain, id: string) => {
+  const client = getClient();


If you want to use fetch on client you need pass prefix here 😇

yes, I already added TODO here https://github.com/kodadot/workers/pull/41/files#diff-a17dc2c4fda697859be2b120d60f29831b5af50e3800aa7930fa3dcc861b325dR22-R23

for now not using client.fetch(query) is because there is no rmrk in the Prefix

rmrk prefix was replaced to ksm

oohh, ok will update that 🙏🏻

socket-security · 2023-03-23T09:31:20Z

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package	Script field	Source
esbuild@0.16.3 (added)	`postinstall`	`ssr-opengraph/package-lock.json` via wrangler@2.13.0

Pull request report summary

Issue	Status
Install scripts	⚠️ 1 issue
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore esbuild@0.16.3

Powered by socket.dev

yangwao · 2023-03-23T12:45:58Z

Somewhre on gaming nft marketplaces I've seen they've been pushing different numbers on card from collections, can create on that issue once I spot it again, that would be amazing to have it, otherwise looking forward to deploying this to beta & production

ssr-opengraph/src/utils.ts

preschian · 2023-03-23T13:53:10Z

@vikiival updated 🙏🏻🙏🏻🙏🏻

preschian · 2023-03-24T02:20:40Z

step to deploy:

after merging this PR, make sure to deploy the prerender-opengraph worker first

and then deploy ssr-opengraph. to avoid routes conflict #41 (files)

can we deploy it also to production? cc @yangwao @vikiival

vikiival · 2023-03-24T13:25:04Z

cc @preschian

➜  prerender-opengraph git:(main) ✗ npx wrangler publish
 ⛅️ wrangler 2.1.13 (update available 2.13.0)
-------------------------------------------------------
Total Upload: 2.34 KiB / gzip: 1.02 KiB
Uploaded prerender-opengraph (3.64 sec)
Published prerender-opengraph (15.99 sec)
  kodadot.xyz/rmrk/detail/*
  kodadot.xyz/bsx/detail/*
  kodadot.xyz/snek/detail/*
  kodadot.xyz/glmr/gallery/*
  kodadot.xyz/glmr/detail/*
➜  prerender-opengraph git:(main) ✗ cd ../ssr-opengraph
➜  ssr-opengraph git:(main) ✗ npx wrangler publish
 ⛅️ wrangler 2.13.0
--------------------

✘ [ERROR] Missing entry-point: The entry-point should be specified via the command line (e.g. `wrangler publish path/to/script`) or the `main` config field.


If you think this is a bug then please create an issue at https://github.com/cloudflare/workers-sdk/issues/new/choose

preschian · 2023-03-24T13:28:09Z

Missing entry-point: The entry-point should be specified via the command line

eh, hhmm

let's try to deploy it through github actions?

preschian · 2023-03-24T13:35:00Z

oohh, you need to run npm run deploy or wrangler publish src/index.tsx

vikiival · 2023-03-24T15:52:30Z

fixed in 6ee53ca

vikiival · 2023-03-24T15:53:23Z

➜  ssr-opengraph git:(main) ✗ npx wrangler publish
 ⛅️ wrangler 2.13.0
--------------------
Total Upload: 218.96 KiB / gzip: 42.82 KiB
Uploaded ssr-opengraph (2.98 sec)
Published ssr-opengraph (17.02 sec)
  kodadot.xyz/rmrk/gallery/*
  kodadot.xyz/rmrk/collection/*
  kodadot.xyz/bsx/gallery/*
  kodadot.xyz/bsx/collection/*
  kodadot.xyz/snek/gallery/*
  kodadot.xyz/snek/collection/*
Current Deployment ID: 4e190bd2-13ca-40ce-9094-0f3f7077f2c4

preschian added 3 commits March 22, 2023 23:16

feat: init ssr-opengraph

c2df5b0

chore: remove some endpoints on prerender-opengraph

9c462fc

feat: use kodadot domain

774c9d3

preschian marked this pull request as ready for review March 22, 2023 16:27

vikiival requested changes Mar 22, 2023

View reviewed changes

feat: use kodadot1 packages

237df48

preschian requested a review from vikiival March 23, 2023 04:30

vikiival requested changes Mar 23, 2023

View reviewed changes

feat: import indexers

a2b7cc5

vikiival reviewed Mar 23, 2023

View reviewed changes

ssr-opengraph/src/utils.ts Outdated Show resolved Hide resolved

feat: rmrk to ksm

209454f

vikiival approved these changes Mar 23, 2023

View reviewed changes

vikiival merged commit 3f9ed12 into kodadot:main Mar 23, 2023

preschian deleted the feat/ssr-opengraph branch March 24, 2023 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: init ssr-opengraph #41

feat: init ssr-opengraph #41

preschian commented Mar 22, 2023 •

edited

Loading

preschian commented Mar 22, 2023

vikiival left a comment

vikiival commented Mar 22, 2023

vikiival commented Mar 22, 2023

vikiival left a comment

vikiival Mar 23, 2023

preschian Mar 23, 2023

vikiival Mar 23, 2023

preschian Mar 23, 2023

vikiival Mar 23, 2023

preschian Mar 23, 2023

socket-security bot commented Mar 23, 2023

yangwao commented Mar 23, 2023

preschian commented Mar 23, 2023

preschian commented Mar 24, 2023

vikiival commented Mar 24, 2023 •

edited

Loading

preschian commented Mar 24, 2023

preschian commented Mar 24, 2023

vikiival commented Mar 24, 2023

vikiival commented Mar 24, 2023

feat: init ssr-opengraph #41

feat: init ssr-opengraph #41

Conversation

preschian commented Mar 22, 2023 • edited Loading

preschian commented Mar 22, 2023

vikiival left a comment

Choose a reason for hiding this comment

vikiival commented Mar 22, 2023

vikiival commented Mar 22, 2023

vikiival left a comment

Choose a reason for hiding this comment

vikiival Mar 23, 2023

Choose a reason for hiding this comment

preschian Mar 23, 2023

Choose a reason for hiding this comment

vikiival Mar 23, 2023

Choose a reason for hiding this comment

preschian Mar 23, 2023

Choose a reason for hiding this comment

vikiival Mar 23, 2023

Choose a reason for hiding this comment

preschian Mar 23, 2023

Choose a reason for hiding this comment

socket-security bot commented Mar 23, 2023

Socket Security Pull Request Report

yangwao commented Mar 23, 2023

preschian commented Mar 23, 2023

preschian commented Mar 24, 2023

vikiival commented Mar 24, 2023 • edited Loading

preschian commented Mar 24, 2023

preschian commented Mar 24, 2023

vikiival commented Mar 24, 2023

vikiival commented Mar 24, 2023

preschian commented Mar 22, 2023 •

edited

Loading

vikiival commented Mar 24, 2023 •

edited

Loading