Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search on top of collections v0.9 #5333

Closed
exezbcz opened this issue Mar 23, 2023 · 7 comments · Fixed by #5851
Closed

Search on top of collections v0.9 #5333

exezbcz opened this issue Mar 23, 2023 · 7 comments · Fixed by #5851
Assignees
Labels
$$ ~51-150usd A-collection work being done collection view A-search related to search components intern tasks intended for internal team p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Mar 23, 2023

Okay, bit experimental feature is here

image

How it works

  • so as you can see, there is small tag in the search bar when you open collection

  • it shows "collection search" - its there because some collection names are really long and not sure whether cropping their name is a good idea - I will once more consider it in the future

  • once you click on the search bar, there is no results dropdown - you are only inputting text and hitting enter

  • if you dont want to search on top off collection, once you focus on the searchbar you can hit backspace to remove the tag and you are searching across whole the app

  • if you hit enter, breadcrumb is added - It has different color so it stands out

  • in figma there is also dark mode version

mobile

  • We're disabling this feature for mobile users first since there are some challenges in providing the best user experience for mobile devices.

Feel free to ask!
thanks

@exezbcz exezbcz added UX first Improvement for UX A-collection work being done collection view design-request labels Mar 23, 2023
@exezbcz exezbcz added p3 non-core, affecting less than 40% and removed design-request labels Mar 29, 2023
@yangwao yangwao added the A-search related to search components label Mar 30, 2023
@yangwao
Copy link
Member

yangwao commented Mar 30, 2023

Hopefully we won't break much anything 😅🤞

@yangwao yangwao added p2 core functionality, or is affecting 60% of app $$ ~51-150usd intern tasks intended for internal team and removed p3 non-core, affecting less than 40% labels Apr 17, 2023
@yangwao
Copy link
Member

yangwao commented Apr 17, 2023

This issue is intented for someone who knows our navbar and search bar quite well and can do it well with understanding current codebase.

Inspiration is how newest GH search works, seems best we've found in industry outside web3

image

@exezbcz
Copy link
Member Author

exezbcz commented Apr 26, 2023

anyone who likes to break things? 👀

@prachi00
Copy link
Member

prachi00 commented Apr 26, 2023

anyone who likes to break things? 👀 68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f4b44513235706168566677475276765439582f67697068792e676966 [ ]

i-volunteer-tribute

@prachi00
Copy link
Member

oh is this only for internel team? I do not volunteer then 😅

@yangwao
Copy link
Member

yangwao commented Apr 30, 2023

Hey @Jarsen136 could you pick up this one ? :)

@Jarsen136 Jarsen136 self-assigned this May 1, 2023
@kodabot
Copy link
Collaborator

kodabot commented May 1, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Thursday, May 4th 2023, 24:57:49 UTC -> 72 hours

@exezbcz exezbcz changed the title Search on top of collections Search on top of collections v0.9 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-collection work being done collection view A-search related to search components intern tasks intended for internal team p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants