-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search items on top of collections #5851
Conversation
SUCCESS @Jarsen136 PR for issue #5333 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request contains several changes in the codebase, summarized as follows:
|
@exezbcz is it something we want to support? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Luke Fishman <daiagi@gmail.com>
Co-authored-by: Luke Fishman <daiagi@gmail.com>
@daiagi yes, Thank you for pointing that out. It's a first version, so there will be changes, and the search recommendations will need to be changed as well - I believe that once we finish this first version, we can move on to adding and refining it. So, right now there is not an option to resume collection search. |
✅ Fixed. |
Amazing!
quick hack for this:
|
✅Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm ✔️
@exezbcz let's drop visual-ok 👀 |
I would like to see some suggestions on writing as query on top of collection is much easier and less heavy to search. Plus for next design can include wrapped name of collection for like 40 chars We can do this as followup |
I would take a try after this PR merged |
Code Climate has analyzed commit cecf4e2 and detected 0 issues on this pull request. View more on Code Climate. |
pay 80 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at c1d6e3b
This pull request adds a new feature to enable searching for collections and within collections on the NFT gallery. It also refactors some utility functions and components, updates import paths, and adds new theme variables and styles for the UI. The main files affected are
components/search/Search.vue
,components/search/SearchBar.vue
,components/search/SearchCollection.vue
,components/shared/BreadcrumbsFilter.vue
,components/shared/gallery/NeoTag.vue
,locales/en.json
,styles/abstracts/_theme.scss
,styles/components/_search.scss
, andcomponents/search/utils/useCollectionSearch.ts
. The rest of the files are mostly import path changes.🤖 Generated by Copilot at c1d6e3b