collectionId in path

[roiLeo]

Step to reproduce:

• go to any chain
• click on explore
• click on any collection item
• you'll have a ?collectionId=... param in path which is redundant

[daiagi]

strange bug
originates from Navbar.vue
deleting all of <b-navbar> children templated stops he bug
putting any of them back (brand, start, end) and the bug returns

[roiLeo]

strange bug originates from Navbar.vue deleting all of <b-navbar> children templated stops he bug putting any of them back (brand, start, end) and the bug returns

Maybe it's comming from Search component which is in template #start
Time to replace b-navbar with Bulma navbar

[daiagi]

nah
it's coming from watch function in SearchBar.vue, related with enabling inside collection search:

• Search items on top of collections  #5851

  @Watch('isSearchInCollectionMode', { immediate: true })
  private onSearchInCollectionModeChanged() {
    const { replaceUrl } = useReplaceUrl()
    replaceUrl({
      collectionId: this.isSearchInCollectionMode
        ? this.$route.params.id
        : undefined,
    })
  }
}

[roiLeo]

nah it's coming from watch function in SearchBar.vue, related with enabling inside collection search:

hmmm... even without this part I still have collectionId= in path

[daiagi]

i don't
but in fact, some url query param is needed as it signals that the search is to happen inside a collection
so maybe change it to something like collection_search=true ?

cc @Jarsen136

[Jarsen136]

but in fact, some url query param is needed as it signals that the search is to happen inside a collection

It's true : )

so maybe change it to something like collection_search=true ?

It would improve a little but it would still bring an extra params collection_search on url. If we would like to remove this param at all, I would try to add a global state store, and share the state with some related component.

[daiagi]

so @roiLeo , what kind of solution you would like to see here?

• url param change => collection_search=true
• hide it away in the store

[roiLeo]

so @roiLeo , what kind of solution you would like to see here?

* [ ]  url param change => collection_search=true

* [ ]  hide it away in the store

I don't understand why you need to check ?collectionId= params when we already have it in the url slug (/:prefix/collection/:id) but basically I'd like to avoid repetition

[daiagi]

I don't understand why you need to check ?collectionId= params when we already have it in the url slug (/:prefix/collection/:id) but basically I'd like to avoid repetition

making the param repeat the collection id was a non ideal design choice, but we still need something to signal if a search is 'confined' to specific collection or not
it really acts as a boolean flag

[roiLeo]

Could you point me to where this part of code is? It seems that I can't find it.

[Jarsen136]

Could you point me to where this part of code is? It seems that I can't find it.

function useCollectionSearch at components/search/utils/useCollectionSearch.ts

[roiLeo]

I found a weird glitch, when you resize browser to mobile/tablet in /:prefix/collection/:id page it remove ?collectionId=:id query param.
issue comes when Searchbar is displayed?

edit: each time I resize browser it throw warning
⚠️ NavigationDuplicated: Avoided redundant navigation to current location: "/snek/collection/3124270296?collectionId=3124270296"

[Jarsen136]

I found a weird glitch, when you resize browser to mobile/tablet in /:prefix/collection/:id page it remove ?collectionId=:id query param. issue comes when Searchbar is displayed?

Yes. It's a special status of the searchbar.

edit: each time I resize browser it throw warning ⚠️ NavigationDuplicated: Avoided redundant navigation to current location: "/snek/collection/3124270296?collectionId=3124270296"

It may not be related to this issue I guess : )

I will work on this one issue with the state store solution.

[kodabot]

ASSIGNED - @Jarsen136 🔒 LOCKED -> Sunday, July 23rd 2023, 24:12:10 UTC -> 36 hours