Install Playwright (cypress dead)

[roiLeo]

On latest PR cypress tests are failing

Process returned exit code 1
Launched as "pnpm start:static & pnpm wait-on http://localhost:9090 && MATRIX=4 node tests/cypress/e2e-run-tests.js"
Launched at "/__w/nft-gallery/nft-gallery"
Attempts exhausted, made 3 attempts :
Attempt #1 started at : 08:04:47 GMT+0000 (Coordinated Universal Time)
Attempt #2 started at : 08:05:18 GMT+0000 (Coordinated Universal Time)
Attempt #3 started at : 08:05:32 GMT+0000 (Coordinated Universal Time)

Task

• migrate to playwright

ref

• https://playwright.dev/docs/intro
• https://www.browserstack.com/guide/playwright-vs-cypress
• https://apiumhub.com/tech-blog-barcelona/playwright-vs-cypress/
• https://betterprogramming.pub/choosing-playwright-over-cypress-deaf060e4a09

[vikiival]

cc @preschian

[vikiival]

migrate to playwrigth?

Yup I think it would be much faster

[yangwao]

• migrate to playwrigth?

yes, we've been researching this one last summer irc

• Introduce basic testing framework #707 (comment)
• Remove Cypress #3046

[yangwao]

@prury this is an ideal opportunity to learn new thing! :)

[preschian]

cc @preschian

migrate to playwrigth?

Yup I think it would be much faster

yes, we've been researching this one last summer irc

yes, I agree with this. since @vikiival already research that a long time ago

[preschian]

I just found out that we removed cypress once before #3052
and then add cypress back #3451

[yangwao]

now we can learn from that mistake, remove it and add playwright 😄

If I get it right, some tests could be recycled?

[prury]

@prury this is an ideal opportunity to learn new thing! :)

oh, definitely, good thing i learned just the basics about cypress and do not went too further
playwright it is then

[prury]

👋

[kodabot]

ASSIGNED - @prury 🔒 LOCKED -> Friday, August 11th 2023, 15:25:29 UTC -> 48 hours

[kodabot]

ASSIGNMENT EXPIRED - @prury has been unassigned.

[prury]

i'm still doing it mr bot

[yangwao]

Any update @prury on this?
Can we have at least partial ones? 😄

[prury]

Any update @prury on this? Can we have at least partial ones? 😄

@yangwao I do have an update, I've been messing with it in the past times, but since the number or PRs was very high i didn't had enough time.
1 - i am using pnpm install --frozen-lockfile in order for it no to update many other dependencies
2 - i did configure a baseURL:

3 - it automatically adds a action to the workflow folder
4 - i am able to run tests locally

problem:

The problem i am facing is related make playwright wait for Netlify to build in order to start the tests, every guide i was seeing uses a third party repo to implement it, examples: wait for netlify 1, wait for netlify 2, wait for netlify 3, and they are rarely being updated, if that's ok, then i'll use this solution, otherwise i want to ask for advice.

other sources: microsoft/playwright#9971

[preschian]

The problem i am facing is related make playwright wait for Netlify to build in order to start the tests

no need to wait for Netlify. just run build and run localhost, and then run playwright to hit that localhost port. that is what we do on Cypress previously

nft-gallery/.github/workflows/e2e.yml

Lines 63 to 68 in bb48d8a

	- name: Run Cypress
	timeout-minutes: 10
	uses: Wandalen/wretry.action@v1.0.41
	with:
	command: pnpm start:static & pnpm wait-on http://localhost:9090 && MATRIX=${{ matrix.index }} node tests/cypress/e2e-run-tests.js
	attempt_limit: 3

[prury]

The problem i am facing is related make playwright wait for Netlify to build in order to start the tests

no need to wait for Netlify. just run build and run localhost, and then run playwright to hit that localhost port. that is what we do on Cypress previously

nft-gallery/.github/workflows/e2e.yml

Lines 63 to 68 in bb48d8a

	- name: Run Cypress
	timeout-minutes: 10
	uses: Wandalen/wretry.action@v1.0.41
	with:
	command: pnpm start:static & pnpm wait-on http://localhost:9090 && MATRIX=${{ matrix.index }} node tests/cypress/e2e-run-tests.js
	attempt_limit: 3

thank you @preschian , will do it when i have the time