Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright Installation #6920

Merged
merged 10 commits into from
Aug 24, 2023
Merged

Playwright Installation #6920

merged 10 commits into from
Aug 24, 2023

Conversation

prury
Copy link
Member

@prury prury commented Aug 23, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

Thanks for all the support, next step: rewriting old cypress tests

Who tests the tests added from the testers automated tests? 🐛

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

@stephenjason89 and @preschian did all the heavy lifting

Community participation

Screenshot 📸

image

Copilot Summary

🤖 Generated by Copilot at 41de705

This pull request introduces Playwright tests for the NFT gallery project. It adds the @playwright/test package and its configuration, a GitHub Actions workflow to run the tests, and a basic test case for the Create Page. It also updates some dependencies and excludes the Playwright tests from Vitest.

🤖 Generated by Copilot at 41de705

To test the NFT gallery site
We added Playwright tests to write
With @playwright/test
And config file set
We run them on GitHub with workflow.yml

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 41de705
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e749eb925edd0008773eb5
😎 Deploy Preview https://deploy-preview-6920--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added the medium Pull request is medium label Aug 23, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@playwright/test 1.37.1 eval, network, filesystem, shell, environment +1 10.2 MB aslushnikov

@stephenjason89
Copy link
Contributor

stephenjason89 commented Aug 24, 2023

Hello @prury, I believe the problem is with the playwright local webServer

so first we don't need this anymore
playwright.config.js
image

second
playwright.config.js
image
We need to point it on our dev server

third to execute the test we need to run our local server
pnpm dev

finally run test ❤️
pnpm exec playwright test
npx playwright show-report

image

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. exlude test/e2e folder on vitest

exclude: [
'**/node_modules/**',
'**/dist/**',
'**/.{idea,git,cache,output,temp}/**',
],

.github/workflows/playwright.yml Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 24, 2023

Code Climate has analyzed commit 41de705 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prury prury marked this pull request as ready for review August 24, 2023 12:24
@prury prury requested a review from a team as a code owner August 24, 2023 12:24
@prury prury requested review from preschian and daiagi and removed request for a team August 24, 2023 12:24
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, next PR,
time to migrate and adjust cypress test to the playwright

@prury
Copy link
Member Author

prury commented Aug 24, 2023

cool, next PR, time to migrate and adjust cypress test to the playwright

yes! Thank you so much @preschian

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ all green

@yangwao yangwao merged commit 80c7cd0 into kodadot:main Aug 24, 2023
16 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 24, 2023

let's go @prury you are learning! :)

@prury
Copy link
Member Author

prury commented Aug 24, 2023

let's go @prury you are learning! :)

thanks to you my friend, i appreciate ❤️

@vikiival
Copy link
Member

Amazing ❤️ ❤️

This was referenced Aug 25, 2023
@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

What is current Playwright test coverage?

@prury
Copy link
Member Author

prury commented Aug 30, 2023

What is current Playwright test coverage?

basically tests if the page exists, can you open issue for me to work on test old cypress tests conversion?
edit: you already did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Playwright (cypress dead)
6 participants