Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart text truncation #6617

Closed
exezbcz opened this issue Aug 8, 2023 · 12 comments
Closed

Cart text truncation #6617

exezbcz opened this issue Aug 8, 2023 · 12 comments
Labels
$ ~<50usd A-cart for faster shoplifiting in kodadot p2 core functionality, or is affecting 60% of app visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Aug 8, 2023

image

  • the nft name is cut even if there is no trash can
  • it would also be nice if the text could be fullsize - taking the container
  • so when you hover over the nft it will be cut to the length needed

image

@exezbcz exezbcz added visual change not affecting ux of app p3 non-core, affecting less than 40% A-cart for faster shoplifiting in kodadot labels Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

Same ?

@exezbcz
Copy link
Member Author

exezbcz commented Aug 8, 2023

@yangwao Hmmm, #6617 is more about the nft name rather than the price. I will look into the collection font size. Not sure whether it would look good. Update soon

@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Aug 10, 2023
@god-of-js
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 10, 2023

ASSIGNED - @god-of-js 🔒 LOCKED -> Friday, August 11th 2023, 13:58:54 UTC -> 24 hours

@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2023

ASSIGNMENT EXPIRED - @god-of-js has been unassigned.

@stephenjason89
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 11, 2023

ASSIGNED - @stephenjason89 🔒 LOCKED -> Saturday, August 12th 2023, 15:57:56 UTC -> 24 hours

@exezbcz
Copy link
Member Author

exezbcz commented Aug 11, 2023

@stephenjason89 hello sir, @god-of-js already raised pr for this issue - #6665. There are some changes that need to be made. If he doesn't make them in time, the issue will be closed and you can work on it.

@stephenjason89
Copy link
Contributor

hello @exezbcz ohh. I already finished.
i thought the bot said
image

@stephenjason89
Copy link
Contributor

stephenjason89 commented Aug 11, 2023

anyway, @exezbcz
here's the fix since i've already done it. #6681
you can use it or close it.

@yangwao please make the kodabot more accurate to avoid situations like this.
So time can be spent on something more productive.

The least we can do for now is updating the issue before timer runs out that work is still in progress and needed extension

Thank you

@kodabot
Copy link
Collaborator

kodabot commented Aug 14, 2023

ASSIGNMENT EXPIRED - @stephenjason89 has been unassigned.

@stephenjason89
Copy link
Contributor

I believe this should be closed @exezbcz

@exezbcz exezbcz closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-cart for faster shoplifiting in kodadot p2 core functionality, or is affecting 60% of app visual change not affecting ux of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants