Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style guide: how to use images in the code #6708

Closed
vikiival opened this issue Aug 14, 2023 · 4 comments · Fixed by #6731
Closed

Style guide: how to use images in the code #6708

vikiival opened this issue Aug 14, 2023 · 4 comments · Fixed by #6731
Labels
$ ~<50usd documentation Improvements or additions to documentation good first issue as new commer, something you could start with

Comments

@vikiival
Copy link
Member

PR #6707 drastically reduced bundle size thanks to offloading images from code into separated folder.

I want that developers SHOULD NOT inline images instead link them as shown in PR - #6707

Into STYLE_GUIDE.md:

  1. Under naming conventions - other - add that images (prefferably webp should be kebab-cased)
  2. under general conventions - images - write that images should not be inlined but referenced also make short snippet
@vikiival vikiival added documentation Improvements or additions to documentation good first issue as new commer, something you could start with $ ~<50usd devrel and removed devrel labels Aug 14, 2023
@yangwao
Copy link
Member

yangwao commented Aug 15, 2023

SHOULD NOT inline images

Can we have a lint rule for this one?

thnaylor added a commit to thnaylor/kodadot-nft-gallery that referenced this issue Aug 15, 2023
@thnaylor
kodadot#6708 - how to use images in code
458c02b
@thnaylor
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 15, 2023

ASSIGNED - @thnaylor 🔒 LOCKED -> Thursday, August 17th 2023, 09:25:47 UTC -> 36 hours

thnaylor added a commit to thnaylor/kodadot-nft-gallery that referenced this issue Aug 15, 2023
@thnaylor
kodadot#6708 - how to use images in code
50d178b
@thnaylor thnaylor mentioned this issue Aug 16, 2023
Merged
6 tasks
thnaylor added a commit to thnaylor/kodadot-nft-gallery that referenced this issue Aug 16, 2023
@thnaylor
kodadot#6708 - changed eslint 'warn' to 'error' & added additional di…
c76b01a 
…rectories for image import check
yangwao added a commit that referenced this issue Aug 17, 2023
@yangwao
Merge pull request #6731 from thnaylor/6708-how-to-use-images-in-code
929a427 
#6708 - how to use images in code
@kodabot
Copy link
Collaborator

kodabot commented Aug 17, 2023

ASSIGNMENT EXPIRED - @thnaylor has been unassigned.

@yangwao yangwao closed this as completed Aug 17, 2023
@vikiival vikiival linked a pull request Aug 17, 2023 that will close this issue
#6708 - how to use images in code #6731
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd documentation Improvements or additions to documentation good first issue as new commer, something you could start with
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6708 - how to use images in code thnaylor/kodadot-nft-gallery
4 participants
@yangwao @thnaylor @vikiival @kodabot