Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing tests #8265

Closed
daiagi opened this issue Nov 27, 2023 · 4 comments · Fixed by #8276
Closed

failing tests #8265

daiagi opened this issue Nov 27, 2023 · 4 comments · Fixed by #8276
Assignees
Labels

Comments

@daiagi
Copy link
Contributor

daiagi commented Nov 27, 2023

https://github.com/kodadot/nft-gallery/actions/runs/7001644591/job/19044052495?pr=8264

image
image

@prury

@roiLeo
Copy link
Contributor

roiLeo commented Nov 27, 2023

we shouldn't test like this on fixed examples on explore page.
Each running test should have a description

i.e. User go to ahp explore page & sort by price ASC

@prury
Copy link
Member

prury commented Nov 27, 2023

we shouldn't test like this on fixed examples on explore page. Each running test should have a description

i.e. User go to ahp explore page & sort by price ASC

trying to understand what you said,
do you mean each step of the testing should have a description or each step should be a different small test with a description?

@roiLeo
Copy link
Contributor

roiLeo commented Nov 27, 2023

trying to understand what you said, do you mean each step of the testing should have a description or each step should be a different small test with a description?

each single test should have a description, no need to run multiple tests on the same scope.
like in current test we don't need to test User go to ahp explore page & sort by price ASC & User go to rmrk explore page & sort by price ASC it's redundant.

@prury
Copy link
Member

prury commented Nov 27, 2023

trying to understand what you said, do you mean each step of the testing should have a description or each step should be a different small test with a description?

each single test should have a description, no need to run multiple tests on the same scope.
like in current test we don't need to test User go to ahp explore page & sort by price ASC & User go to rmrk explore page & sort by price ASC it's redundant.

Sure, agree about the routes, will keep only the one on Ahk on the explore test and will look for more redundant tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants