Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Collection and explore tests failing #8276

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fix/Collection and explore tests failing #8276

merged 3 commits into from
Nov 28, 2023

Conversation

prury
Copy link
Member

@prury prury commented Nov 27, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

explore.spec.ts flakiness may not have been mitigated properly yet, still trying to find the root cause

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Test error

Context

Copilot Summary

🤖[deprecated] Generated by Copilot at f79de20

The pull request enhances the e2e tests for collections and items by reorganizing them into separate files and functions, and by adding more steps and assertions. This improves the test coverage and readability of the code.

🤖[deprecated] Generated by Copilot at f79de20

We test the explore pages with fire and steel
We split the code and rename the spec
We scroll and filter to reveal the truth
We refactor the code to make it perfect

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c906f95
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6564c56786e7d30008691e53
😎 Deploy Preview https://deploy-preview-8276--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 27, 2023

AI-Generated Summary: This pull request includes two patches. The first patch is focused on fixing the collection test. Changes include renaming the test from "Collection" to "Collection interactions", adding new commands to scroll down, adjusting event checkbox interactions, and making sure each checkbox is unchecked before moving on to the next one. The second patch is an attempt to fix explore test flakiness. It revises the tests for exploring collections and individual items, changes the input for price filtering, and makes commands work now in a more descriptive and independent way. Notably, the second patch cuts down the repetitive testing for different routes and only keeps testing for a specific route.

@reviewpad reviewpad bot added the medium Pull request is medium label Nov 27, 2023
@prury prury marked this pull request as ready for review November 27, 2023 16:35
@prury prury requested a review from a team as a code owner November 27, 2023 16:35
@prury prury requested review from preschian and roiLeo and removed request for a team November 27, 2023 16:35
Copy link

codeclimate bot commented Nov 27, 2023

Code Climate has analyzed commit c906f95 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury requested review from Jarsen136 and removed request for preschian November 27, 2023 18:50
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Nov 28, 2023
@yangwao yangwao merged commit bef4c70 into main Nov 28, 2023
17 checks passed
@yangwao yangwao deleted the fix/pw-tests branch November 28, 2023 12:32
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing tests
3 participants