Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grid item skeleton cards size issue #10040

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

floyd-li
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
record.mov

@floyd-li floyd-li requested a review from a team as a code owner April 10, 2024 07:06
@floyd-li floyd-li requested review from daiagi and hassnian and removed request for a team April 10, 2024 07:06
@kodabot
Copy link
Collaborator

kodabot commented Apr 10, 2024

SUCCESS @floyd-li PR for issue #9377 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 88d1c67
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66164f8a727ad7000763eb4d
😎 Deploy Preview https://deploy-preview-10040--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

components/shared/nftCard/NftCardSkeleton.vue Outdated Show resolved Hide resolved
components/shared/nftCard/NftCardSkeleton.vue Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Apr 10, 2024

Code Climate has analyzed commit 88d1c67 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury changed the title fix: grid item skelton cards size issue fix: grid item skeleton cards size issue Apr 10, 2024
@prury
Copy link
Member

prury commented Apr 10, 2024

@floyd-li please resolve conversations

@prury
Copy link
Member

prury commented Apr 10, 2024

there is a super small skeleton shifting when you browse profile, no need to fix if its too complicated

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 10, 2024
@prury
Copy link
Member

prury commented Apr 11, 2024

@daiagi please check if conversations are good to go

@daiagi
Copy link
Contributor

daiagi commented Apr 11, 2024

@prury

all good. may continue

@prury prury added this pull request to the merge queue Apr 11, 2024
Merged via the queue into kodadot:main with commit f559c35 Apr 11, 2024
19 checks passed
@prury
Copy link
Member

prury commented Apr 11, 2024

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Apr 11, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 8.26 USD/DOT ~ 3.632 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0xd2e1da10fec9d57ba3e7b382bd2e8d294e0a3d0abb08412bef188ea1707dd51b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 11, 2024
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items grid skelton cards size doesn't match normal cards size
6 participants