Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Code-Checker: Resizing screen #10045

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 10, 2024 12:12
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team April 10, 2024 12:12
@kodabot
Copy link
Collaborator

kodabot commented Apr 10, 2024

WARNING @Jarsen136 PR for issue #10044 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #10044

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit be852c3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/661682121a79340008f9704b
😎 Deploy Preview https://deploy-preview-10045--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 10, 2024

Code Climate has analyzed commit be852c3 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarsen136 the screenshot you chose does not illustrate the benefits very well 😆

but it works and lgtm

@Jarsen136
Copy link
Contributor Author

@Jarsen136 the screenshot you chose does not illustrate the benefits very well 😆

but it works and lgtm

Indeed. I should have recorded a short video to show the changes better 😄

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 10, 2024
@prury prury added this pull request to the merge queue Apr 11, 2024
Merged via the queue into kodadot:main with commit fd0c94a Apr 11, 2024
19 checks passed
@prury
Copy link
Member

prury commented Apr 11, 2024

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Apr 11, 2024

😍 Perfect, I’ve sent the payout
💵 $20 @ 8.26 USD/DOT ~ 2.421 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xe15613d0bc6244a350ee664a9cd77a4495cb95fa21fcd97eff144f6f6e2a70d3

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 11, 2024
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code-Checker: Resizing screen
6 participants