Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New to koda? Connect wallet sidebar improvements #10052

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 10, 2024 20:48
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team April 10, 2024 20:48
@kodabot
Copy link
Collaborator

kodabot commented Apr 10, 2024

SUCCESS @Jarsen136 PR for issue #10041 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 772ceec
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/661ff654dd86e80008006930
😎 Deploy Preview https://deploy-preview-10052--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff

@prury
Copy link
Member

prury commented Apr 11, 2024

✔️
image

@prury prury requested a review from exezbcz April 11, 2024 14:38
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 11, 2024
Co-authored-by: Luke Fishman <daiagi@gmail.com>
@Jarsen136 Jarsen136 requested a review from daiagi April 11, 2024 15:52
@exezbcz
Copy link
Member

exezbcz commented Apr 13, 2024

gm

looks good, only the font sizes are off

could you have a look at the font sizes please?

image

Fonts

image

paragraphs have 14px font size

image
this is 16px bold

image

learn more is 14px

@exezbcz
Copy link
Member

exezbcz commented Apr 16, 2024

👀

@exezbcz exezbcz added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 16, 2024
@Jarsen136
Copy link
Contributor Author

gm

looks good, only the font sizes are off

could you have a look at the font sizes please?

✅ DONE

@exezbcz exezbcz removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 17, 2024
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Copy link

codeclimate bot commented Apr 17, 2024

Code Climate has analyzed commit 772ceec and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jarsen136 Jarsen136 added this pull request to the merge queue Apr 18, 2024
Merged via the queue into kodadot:main with commit 166636a Apr 18, 2024
19 checks passed
@Jarsen136 Jarsen136 deleted the issue-10041 branch April 18, 2024 21:42
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New to koda? Connect wallet sidebar improvements
6 participants