Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gallery item genart animation not working #10075

Merged
1 commit merged into from
Apr 22, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 15, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

gen art 1

CleanShot 2024-04-15 at 11 23 49

gen art 2

CleanShot 2024-04-15 at 11 23 13

nft with video

CleanShot 2024-04-15 at 11 24 08

@hassnian hassnian requested a review from a team as a code owner April 15, 2024 06:40
@hassnian hassnian requested review from daiagi and Jarsen136 and removed request for a team April 15, 2024 06:40
@kodabot
Copy link
Collaborator

kodabot commented Apr 15, 2024

SUCCESS @hassnian PR for issue #10071 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 56f2dcf
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/661ccbf1ad5fb1000895d7cf
😎 Deploy Preview https://deploy-preview-10075--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 15, 2024

Code Climate has analyzed commit 56f2dcf and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@hassnian hassnian changed the title fix: Packing gallery item detail fix: gallery item genart animation not working Apr 16, 2024
@prury-temporary
Copy link

works-for-me

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into kodadot:main in 8b23207 Apr 22, 2024
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 22, 2024
@hassnian hassnian deleted the issue-10071 branch April 23, 2024 02:52
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electronik: Wrong view Packing gallery item detail
6 participants