Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open in New Tab not working #10077

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 15, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

test case: https://canary.kodadot.xyz/ahp/gallery/115-2404190282

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 15, 2024 12:12
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team April 15, 2024 12:12
@kodabot
Copy link
Collaborator

kodabot commented Apr 15, 2024

WARNING @Jarsen136 PR for issue #10004 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #10004

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8b40f5e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/661d19be92fd90000818c7fd
😎 Deploy Preview https://deploy-preview-10077--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 15, 2024

Code Climate has analyzed commit 8b40f5e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

@daiagi
Copy link
Contributor

daiagi commented Apr 15, 2024

test case: https://kodadot.xyz/ahp/gallery/115-2404190282

isn't it suppose to be broken in prod?

it works for me

@Jarsen136
Copy link
Contributor Author

test case: https://kodadot.xyz/ahp/gallery/115-2404190282

isn't it suppose to be broken in prod?

it works for me

My bad. I should have put the wrong link. It is supposed to be broken on canary

https://canary.kodadot.xyz/ahp/gallery/115-2404190282

@vikiival vikiival added this pull request to the merge queue Apr 15, 2024
Merged via the queue into kodadot:main with commit f1e03ee Apr 15, 2024
19 checks passed
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in New Tab not working
5 participants