Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Same mobile top modal styling as on desktop #10079

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 15, 2024 20:00
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team April 15, 2024 20:00
@kodabot
Copy link
Collaborator

kodabot commented Apr 15, 2024

SUCCESS @Jarsen136 PR for issue #10078 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f9c127f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662574f0480c4b00087dfa00
😎 Deploy Preview https://deploy-preview-10079--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury-temporary
Copy link

i think it affected the connect wallet modal:

image

filter x icon looks good now

@Jarsen136
Copy link
Contributor Author

i think it affected the connect wallet modal:

Good catch. It's a weird side effect but fixed now.

Copy link

codeclimate bot commented Apr 21, 2024

Code Climate has analyzed commit f9c127f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.8% Duplication on New Code

See analysis details on SonarCloud

@prury-temporary
Copy link

works-for-me

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 22, 2024
@prury prury added this pull request to the merge queue Apr 22, 2024
Merged via the queue into kodadot:main with commit 2a385ec Apr 22, 2024
18 of 19 checks passed
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same mobile top modal styling as on desktop
6 participants