Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell to v5 #10088

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Update ParaSpell to v5 #10088

merged 2 commits into from
Apr 23, 2024

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Apr 16, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

The update features v5 SDK package (No breaking changes for the builder pattern). We introduced custom multilocations in this update.

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases
  • Tested, builds, able to send currency

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@dudo50 dudo50 requested a review from a team as a code owner April 16, 2024 15:55
@dudo50 dudo50 requested review from Jarsen136 and hassnian and removed request for a team April 16, 2024 15:55
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 79f5450
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66276f1e7b47070008670ddc
😎 Deploy Preview https://deploy-preview-10088--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@paraspell/sdk@5.1.0 None +1 478 kB dudo50
npm/@polkadot/extension-inject@0.46.8 Transitive: network +6 25.7 MB polkadotjs
npm/@polkadot/types@10.12.2 None +6 4.77 MB polkadotjs
npm/@polkadot/ui-keyring@3.6.5 None +1 319 kB polkadotjs
npm/@polkadot/ui-settings@3.6.5 environment +2 207 kB polkadotjs
npm/@polkadot/util-crypto@12.6.2 None +14 5.84 MB polkadotjs
npm/@polkadot/vue-identicon@3.6.5 None +2 228 kB polkadotjs
npm/@ramp-network/ramp-instant-sdk@4.0.5 None +1 390 kB jakubsta
npm/@transak/transak-sdk@1.4.1 None 0 67.7 kB kutsav
npm/@types/jest@27.5.2 None 0 71.4 kB types
npm/@types/lodash@4.17.0 None 0 862 kB types
npm/@types/markdown-it@13.0.7 None +2 48.2 kB types
npm/@types/node@20.12.5 None 0 2.03 MB types
npm/@types/prismjs@1.26.3 None 0 19.2 kB types
npm/@typescript-eslint/eslint-plugin@6.21.0 None +10 5.24 MB jameshenry
npm/@typescript-eslint/parser@6.21.0 None +4 1.37 MB jameshenry
npm/@vite-pwa/nuxt@0.6.0 Transitive: environment, filesystem +7 1.17 MB userquin
npm/@vitejs/plugin-vue@4.6.2 environment 0 185 kB vitebot
npm/@vitejs/plugin-vue@5.0.4 environment 0 185 kB vitebot
npm/@vitest/coverage-c8@0.33.0 Transitive: filesystem, unsafe +9 795 kB oreanno
npm/@vitest/coverage-istanbul@0.34.6 None 0 16.3 kB oreanno
npm/@vueuse/core@9.13.0 network +3 1.36 MB antfu
npm/@vueuse/nuxt@9.13.0 Transitive: environment, filesystem +8 1.35 MB antfu
npm/autoprefixer@10.4.19 environment Transitive: filesystem +2 2.26 MB ai
npm/bulma@0.9.4 None 0 1.26 MB jgthms
npm/changelogen@0.5.5 environment, network Transitive: filesystem +5 299 kB pi0
npm/chart.js@4.4.2 None +1 5.01 MB chartjs-ci
npm/chartjs-adapter-date-fns@3.0.0 None 0 288 kB chartjs-ci
npm/chartjs-plugin-zoom@2.0.1 None 0 87.7 kB chartjs-ci

🚮 Removed packages: npm/@paraspell/sdk@4.1.1, npm/consola@3.2.3, npm/glob@8.1.0, npm/lodash@4.17.21

View full report↗︎

Copy link

codeclimate bot commented Apr 16, 2024

Code Climate has analyzed commit f1ed2d9 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @dudo50 🩵🥹

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 22, 2024
@vikiival vikiival merged commit 27aac7c into kodadot:main Apr 23, 2024
10 of 13 checks passed
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants