Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Notifications system redesign #10096

Merged
merged 29 commits into from
Apr 26, 2024
Merged

feat: Notifications system redesign #10096

merged 29 commits into from
Apr 26, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 18, 2024 •
edited

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

new design

CleanShot 2024-04-18 at 15 04 48

CleanShot 2024-04-18 at 15 04 18@2x

friendly error messages

CleanShot 2024-04-22 at 10 43 48@2x

@kodabot
Copy link
Collaborator

kodabot commented Apr 18, 2024

WARNING @hassnian PR for issue #10090 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #10090

@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 14afc93
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6620f0735aa1d60008c32540
😎 Deploy Preview https://deploy-preview-10096--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 50747c2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662bebf27942f0000850c38a
😎 Deploy Preview https://deploy-preview-10096--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review April 18, 2024 12:32
@hassnian hassnian requested a review from a team as a code owner April 18, 2024 12:32
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team April 18, 2024 12:32
Jarsen136
Jarsen136 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise code lgtm

libs/ui/src/components/NeoMessage/NeoMessage.vue Outdated Show resolved Hide resolved
preschian
preschian approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice design 🚀

just minor stuff, otherwise code lgtm

components/common/Notification.vue Outdated Show resolved Hide resolved
libs/ui/src/components/NeoMessage/NeoMessage.vue Show resolved Hide resolved
@hassnian hassnian changed the title feat: Toast notifications redesign feat: Notifications system redesign Apr 22, 2024
codeclimate[bot]
codeclimate bot reviewed Apr 22, 2024
View reviewed changes
utils/error.ts Outdated Show resolved Hide resolved
@prury
Copy link
Member

prury commented Apr 24, 2024 •
edited

  • seems ok ✅ :
    image

  • lacking background color(massmint mobile warning) ❌ :
    image

  • nice ✅ :
    image

  • mobile seems good: ✅
    image

  • cancelling a transfer: (maybe here change it to Transaction was cancelled like it is on drops?)
    image

  • hover on warning working properly ✅

was not able to reproduce a critical one but let's go, very nice work @hassnian and @exezbcz

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 24, 2024
@vikiival
Copy link
Member

Why does the first case has 2 diff styles

@exezbcz
Copy link
Member

exezbcz commented Apr 25, 2024

@vikiival did not specify the style yet, will be followup

@vikiival
Copy link
Member

@vikiival did not specify the style yet, will be followup

Ah so

Screenshot 2024-04-25 at 14 36 45

@exezbcz
Copy link
Member

exezbcz commented Apr 25, 2024

  • cancelling a transfer: (maybe here change it to Transaction was cancelled like it is on drops?)

yeah and the "report issue" should not be there

@hassnian
Copy link
Contributor Author

  • lacking background color(massmint mobile warning) ❌ :
    image

this didn't change, checked with @exezbcz and he is ok with having these styles

  • cancelling a transfer: (maybe here change it to Transaction was cancelled like it is on drops?)

yeah and the "report issue" should not be there

fixed 9d702b3

CleanShot 2024-04-26 at 09 10 19

CleanShot 2024-04-26 at 09 19 00

@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 26, 2024

Code Climate has analyzed commit 50747c2 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Apr 26, 2024
@prury prury requested review from exezbcz and Jarsen136 April 26, 2024 18:03
@prury
Copy link
Member

prury commented Apr 26, 2024

@Jarsen136 re-request a review from you by accident, srry

@prury prury added this pull request to the merge queue Apr 26, 2024
Merged via the queue into kodadot:main with commit 2da864d Apr 26, 2024
18 of 19 checks passed
@prury prury deleted the issue-10090 branch April 26, 2024 19:45
This was referenced May 2, 2024
Merged
Merged
This was referenced May 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival left review comments

@codeclimate codeclimate[bot] codeclimate left review comments

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@exezbcz exezbcz Awaiting requested review from exezbcz

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
7 participants
@hassnian @kodabot @prury @vikiival @exezbcz @preschian @Jarsen136