Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Farcaster frame mint is live - notification on landing page #10112

Merged
merged 10 commits into from
Apr 24, 2024
Merged

feat: Farcaster frame mint is live - notification on landing page #10112

merged 10 commits into from
Apr 24, 2024
+67 −2

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 20, 2024 15:55
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team April 20, 2024 15:55
@kodabot
Copy link
Collaborator

kodabot commented Apr 20, 2024

WARNING @Jarsen136 PR for issue #10111 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #10111

@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e934197
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662967684acf160008f52dba
😎 Deploy Preview https://deploy-preview-10112--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Apr 20, 2024

Looking good! thank you

hassnian
hassnian reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff

utils/drop.ts Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
components/landing/FarcasterMintNotificationBanner.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Apr 22, 2024

one thing maybe, is it dynamic? e.g. does it take the img and a name from some sort of database so it can be updated without release?

@Jarsen136
Copy link
Contributor Author

small stuff

Thanks, all updated

@Jarsen136
Copy link
Contributor Author

one thing maybe, is it dynamic? e.g. does it take the img and a name from some sort of database so it can be updated without release?

No, it's a static config. Currently, we do not have the API to achieve it.

@prury-temporary
Copy link

works-for-me

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 22, 2024
preschian
preschian approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise code lgtm

components/landing/HeroBanner.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Apr 22, 2024

maybe if you could switch the img and name to this
image

and link to this: https://warpcast.com/th0mas-art/0x47bfc921

@Jarsen136
Copy link
Contributor Author

maybe if you could switch the img and name to this image

and link to this: https://warpcast.com/th0mas-art/0x47bfc921

✅ Done
image

@exezbcz
Copy link
Member

exezbcz commented Apr 23, 2024

thanks a lot, letsgo

@prury prury enabled auto-merge April 23, 2024 12:47
@prury prury added the S-resolve-conversations there are pending conversations that needs to be resolved before merging label Apr 23, 2024
hassnian
hassnian approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove that since it's not used anymore

utils/drop.ts Outdated Show resolved Hide resolved
@Jarsen136 @hassnian
Update drop.ts
78e5f49 
Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
preschian
preschian approved these changes Apr 24, 2024
View reviewed changes
components/landing/HeroBanner.vue Outdated Show resolved Hide resolved
@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 24, 2024

Code Climate has analyzed commit e934197 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue Apr 24, 2024
Merged via the queue into kodadot:main with commit e80e30f Apr 24, 2024
19 checks passed
This was referenced Apr 25, 2024
Merged
Merged
This was referenced May 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exezbcz exezbcz exezbcz approved these changes

@preschian preschian preschian approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
S-resolve-conversations there are pending conversations that needs to be resolved before merging S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Farcaster frame mint is live - notification on landing page
7 participants
@Jarsen136 @kodabot @exezbcz @prury-temporary @preschian @hassnian @prury