Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile-creation #10114

Merged
merged 24 commits into from
Apr 26, 2024
Merged

Profile-creation #10114

merged 24 commits into from
Apr 26, 2024

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Apr 21, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Notes

  • Requires worker deployment
  • Only profile creation is fully working in this PR, Edit in follow up

@daiagi daiagi requested a review from a team as a code owner April 21, 2024 16:33
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team April 21, 2024 16:33
@kodabot
Copy link
Collaborator

kodabot commented Apr 21, 2024

WARNING @daiagi PR for issue #9879 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9879

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7d87e1e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6629092470bee8000815a776
😎 Deploy Preview https://deploy-preview-10114--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

services/profile.ts Outdated Show resolved Hide resolved
services/profile.ts Outdated Show resolved Hide resolved
services/profile.ts Show resolved Hide resolved
components/common/successfulModal/ShareSocialsSection.vue Outdated Show resolved Hide resolved
services/profile.ts Outdated Show resolved Hide resolved
services/profile.ts Outdated Show resolved Hide resolved
components/profile/ProfileDetailV3.vue Outdated Show resolved Hide resolved
services/profile.ts Outdated Show resolved Hide resolved
components/profile/ProfileDetailV3.vue Show resolved Hide resolved
@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 22, 2024
@prury
Copy link
Member

prury commented Apr 23, 2024

since my profile is empty and its the first time i'm acessing it, it should show create profile according to @exezbcz
maybe it will only work after worker implementation?

image

@prury
Copy link
Member

prury commented Apr 23, 2024

only mobile thing:
image

@prury
Copy link
Member

prury commented Apr 23, 2024

huge work on both front and backend @daiagi! nice!

@daiagi
Copy link
Contributor Author

daiagi commented Apr 24, 2024

since my profile is empty and its the first time i'm acessing it, it should show create profile according to @exezbcz

still happening?

only mobile thing:

fixed

services/profile.ts Show resolved Hide resolved
services/profile.ts Show resolved Hide resolved
@prury
Copy link
Member

prury commented Apr 24, 2024

small thing:
profile creation modal appears after you close button on submit modal:

profilecreation.webm

otherwise looks good to me

@prury prury requested a review from exezbcz April 24, 2024 12:40
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Apr 24, 2024

Code Climate has analyzed commit 7d87e1e and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

This was referenced Apr 25, 2024
@exezbcz
Copy link
Member

exezbcz commented Apr 25, 2024

nice job!

created this issue, dont wantt to block the issue if its ready from the dev perspective

here are followups for profile creation, up to you whether you want to combine it with this pr

@daiagi
Copy link
Contributor Author

daiagi commented Apr 25, 2024

Thanks @exezbcz
Its very considerate of you to put it in a new issue

I'll handle it over there

@prury prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 25, 2024
@prury
Copy link
Member

prury commented Apr 26, 2024

ah, let's merge this one and i'll open issue when worker gets working

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 26, 2024
@prury prury added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 92bc7e9 Apr 26, 2024
18 of 19 checks passed
@prury prury deleted the profile-creation branch April 26, 2024 17:45
@daiagi
Copy link
Contributor Author

daiagi commented Apr 27, 2024

@prury

worker is up

https://deploy-preview-10114--koda-canary.netlify.app/ahp/u/1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8?redesign=true

This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offchain profile creation flow
6 participants