Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paid mint modal can't try again after transaction error #10118

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-04-22.at.15.41.09.mp4

@hassnian hassnian requested a review from a team as a code owner April 22, 2024 10:52
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team April 22, 2024 10:52
@kodabot
Copy link
Collaborator

kodabot commented Apr 22, 2024

WARNING @hassnian PR for issue #10116 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #10116

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7953a00
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6627a7a1b9e1e10008c79a93
😎 Deploy Preview https://deploy-preview-10118--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented Apr 22, 2024

any method to trigger the error?

edit: let's merge and check if error happens

Copy link

codeclimate bot commented Apr 23, 2024

Code Climate has analyzed commit 7953a00 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue Apr 23, 2024
Merged via the queue into kodadot:main with commit 10db10e Apr 23, 2024
19 checks passed
@prury prury deleted the issue-10116 branch April 23, 2024 14:56
This was referenced Apr 25, 2024
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paid mint modal can't try again after transaction error
5 participants