Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top up all packages #10130

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Top up all packages #10130

merged 5 commits into from
Apr 23, 2024

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Apr 23, 2024

  • ⬆️ deps
  • ⬆️ polkadot 10.13.1
  • ⬆️ kodadot // sub-api

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

Context

Top up all polkadot packages + need identicon for BASE :)

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2024-04-23 at 10 33 21

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1f4d556
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6627890bef2d400008ec45c5
😎 Deploy Preview https://deploy-preview-10130--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival marked this pull request as ready for review April 23, 2024 08:34
@vikiival vikiival requested a review from a team as a code owner April 23, 2024 08:34
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team April 23, 2024 08:34
Copy link

codeclimate bot commented Apr 23, 2024

Code Climate has analyzed commit 1f4d556 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival
Copy link
Member Author

@prury-temporary can u please check?

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@prury
Copy link
Member

prury commented Apr 23, 2024

checking

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 23, 2024
@vikiival vikiival added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit b45df8f Apr 23, 2024
19 checks passed
@vikiival vikiival deleted the chore/package-up branch April 23, 2024 17:58
This was referenced Apr 25, 2024
@vikiival
Copy link
Member Author

vikiival commented May 1, 2024

@vikiival vikiival mentioned this pull request May 1, 2024
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants