Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Lower deposit on AssetHub Kusama #10131

Merged
merged 2 commits into from
Apr 23, 2024
Merged

🧪 Lower deposit on AssetHub Kusama #10131

merged 2 commits into from
Apr 23, 2024

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Apr 23, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Test

Context

Screenshot 2024-04-23 at 10 47 35

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival requested a review from a team as a code owner April 23, 2024 08:47
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team April 23, 2024 08:47
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8bc458d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662778461c9840000842cfb0
😎 Deploy Preview https://deploy-preview-10131--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 23, 2024

Code Climate has analyzed commit 8bc458d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival merged commit 9a40aa6 into main Apr 23, 2024
19 checks passed
@vikiival vikiival deleted the fix/lower-deposits branch April 23, 2024 10:10
This was referenced Apr 25, 2024
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant