Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text changes to Contribution.md #10147

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Some text changes to Contribution.md #10147

merged 3 commits into from
Apr 26, 2024

Conversation

prury
Copy link
Member

@prury prury commented Apr 25, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Tried to improve our contribution file, removed some PR templates and some deprecated info

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e3de330
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662a9ba4f2b3760008b47e91
😎 Deploy Preview https://deploy-preview-10147--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member Author

prury commented Apr 25, 2024

@exezbcz

Copy link
Member

@exezbcz exezbcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise good upgrade, thank you!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codeclimate bot commented Apr 25, 2024

Code Climate has analyzed commit e3de330 and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member Author

prury commented Apr 25, 2024

@kodadot/internal nailed it down to 2 PR templates only, wdyt?

@exezbcz
Copy link
Member

exezbcz commented Apr 25, 2024

@kodadot/internal nailed it down to 2 PR templates only, wdyt?

yup, works for me, i am tagged in every pr already anyway

@prury prury marked this pull request as ready for review April 26, 2024 03:33
@prury prury requested a review from a team as a code owner April 26, 2024 03:33
@prury prury requested review from preschian and Jarsen136 and removed request for a team April 26, 2024 03:33
@JustLuuuu
Copy link
Member

wfm

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vikiival vikiival added this pull request to the merge queue Apr 26, 2024
@vikiival
Copy link
Member

GJ!

Merged via the queue into main with commit 8d6fa3e Apr 26, 2024
19 checks passed
@vikiival vikiival deleted the contribution-guidelines branch April 26, 2024 10:51
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants