Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Mint button in confirm modal for drops #10152

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 26, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

@hassnian hassnian requested a review from a team as a code owner April 26, 2024 08:59
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team April 26, 2024 08:59
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit fa79363
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662c6e7455bede0008e3d0a2
😎 Deploy Preview https://deploy-preview-10152--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Apr 26, 2024

woho nice
image

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's easy to reuse this animation effect on other buttons now.

libs/ui/src/components/NeoButton/NeoButton.scss Outdated Show resolved Hide resolved
@prury
Copy link
Member

prury commented Apr 26, 2024

Gravacao.de.tela.de.26-04-2024.14.56.42.webm

@exezbcz do you think its too fast on mobile or nah?
desktop looks nice

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 26, 2024
Copy link

codeclimate bot commented Apr 27, 2024

Code Climate has analyzed commit fa79363 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue Apr 28, 2024
Merged via the queue into kodadot:main with commit fd63cbe Apr 28, 2024
19 checks passed
@prury prury deleted the issue-10150 branch April 28, 2024 20:58
This was referenced May 2, 2024
@prury prury mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mint button in confirm modal for drops
5 participants