Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Autoteleport modal closing when clicking outside #10159

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 28, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Clicking outside to close the modal will only work if all steps are completed

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-04-28.at.15.38.28.mp4

@hassnian hassnian requested a review from a team as a code owner April 28, 2024 10:33
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team April 28, 2024 10:33
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f6fb6dd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/662e260b119bef000803a4a7
😎 Deploy Preview https://deploy-preview-10159--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 28, 2024

Code Climate has analyzed commit f6fb6dd and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury changed the title fix: Autotelport modal closing when clicking outside fix: Autoteleport modal closing when clicking outside Apr 29, 2024
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 29, 2024
@prury prury added this pull request to the merge queue Apr 30, 2024
Merged via the queue into kodadot:main with commit 4ea836f Apr 30, 2024
19 checks passed
@prury prury deleted the can-cancel--autoteleport-modal branch April 30, 2024 11:12
This was referenced May 2, 2024
@prury prury mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoteleport modal closing when clicking outside
4 participants