Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New Profile creation/editing better field validation/error handling #10169

Merged
merged 4 commits into from
May 2, 2024
Merged

fix: New Profile creation/editing better field validation/error handling #10169

merged 4 commits into from
May 2, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

goes after #10140

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Kapture 2024-04-30 at 13 02 46
image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 30, 2024 11:06
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team April 30, 2024 11:06
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5261de6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66338f8e9e01b5000819c3a4
😎 Deploy Preview https://deploy-preview-10169--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daiagi daiagi changed the base branch from main to Edit-Profile April 30, 2024 12:16
@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

@Jarsen136

Ive changed base branch

This allows to focus on your changes more clearly

Base branch will automatically change to main after the other pr is merged and it's branch deleted

@Jarsen136
Copy link
Contributor Author

Base branch will automatically change to main after the other pr is merged and it's branch deleted

Thanks, that's good.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 30, 2024
@prury
Copy link
Member

prury commented Apr 30, 2024

thank you very much @Jarsen136

@prury prury deleted the branch kodadot:main April 30, 2024 16:40
@prury prury closed this Apr 30, 2024
@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

@prury why close?

@prury
Copy link
Member

prury commented Apr 30, 2024

@prury why close?

it was automatic, i did not clicked on close

@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

openinig

@prury
Copy link
Member

prury commented Apr 30, 2024

openinig

i think jarsen has to change branch to main and reopen

@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

i think jarsen has to change branch to main and reopen

indeed

i can't seem to change the base branch

@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

open

1 similar comment
@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

open

@daiagi daiagi reopened this Apr 30, 2024
@daiagi daiagi changed the base branch from Edit-Profile to main April 30, 2024 16:51
@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024

@Jarsen136

I've resolved merge conflicts for you
434b418

hope you don't mind

@daiagi daiagi mentioned this pull request Apr 30, 2024
Merged
4 tasks
@Jarsen136
Copy link
Contributor Author

@Jarsen136

I've resolved merge conflicts for you 434b418

hope you don't mind

Thanks, never mind.

It looks like github would not automatically handle the case of the base branch change.

@daiagi
Copy link
Contributor

daiagi commented Apr 30, 2024 •
edited

@Jarsen136 somehow it did work for me very well recently

I'm guessing it's because I was branching a pr off of my own branches

Screenshot_2024-04-30-21-20-56-83_320a9a695de7cdce83ed5281148d6f19.jpg

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 2, 2024

Code Climate has analyzed commit 5261de6 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue May 2, 2024
Merged via the queue into kodadot:main with commit 17aa2a3 May 2, 2024
19 checks passed
@prury prury mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@daiagi daiagi daiagi approved these changes

@hassnian hassnian Awaiting requested review from hassnian hassnian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Profile creation/editing better field validation/error handling
4 participants
@Jarsen136 @daiagi @prury @preschian