Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 0 nfts in congrats modal #10171

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: 0 nfts in congrats modal #10171

merged 2 commits into from
May 1, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 30, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Couldn't reproduce but this should fix it

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-04-30.at.17.20.27.mp4

@hassnian hassnian requested a review from a team as a code owner April 30, 2024 12:24
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team April 30, 2024 12:24
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 19e4f71
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6630e3e00727030008bd0dc9
😎 Deploy Preview https://deploy-preview-10171--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit 19e4f71 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Apr 30, 2024

made some tests and for me it worked ok, but the mentioned issue never happened to me.
I'll keep watching if it happens, @exezbcz please reopen the issue if it happens again as well

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 30, 2024
@vikiival vikiival added this pull request to the merge queue May 1, 2024
Merged via the queue into kodadot:main with commit dcf5a12 May 1, 2024
19 checks passed
This was referenced May 2, 2024
@prury prury mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 nfts in congrats modal
5 participants