Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell to v5.2.1 #10172

Merged
merged 1 commit into from
May 1, 2024
Merged

Update ParaSpell to v5.2.1 #10172

merged 1 commit into from
May 1, 2024

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Apr 30, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

Needs QA check

Context

This PR features the latest version of the ParaSpell package. In the latest version, we introduced fully custom multilocation support as well as custom fee asset selection. The next version will include the assetClaim function that will allow users to recover assets they lost during issues with XCM. We will contact the Kodadot team about the implementation then.

  • Closes #<issue_number>
  • Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@dudo50 dudo50 requested a review from a team as a code owner April 30, 2024 14:01
@dudo50 dudo50 requested review from preschian and Jarsen136 and removed request for a team April 30, 2024 14:01
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bcfa3e5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6630f9d047947f00082112f5
😎 Deploy Preview https://deploy-preview-10172--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit bcfa3e5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@paraspell/sdk@5.1.0

View full report↗︎

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 30, 2024
@vikiival vikiival added this pull request to the merge queue May 1, 2024
Merged via the queue into kodadot:main with commit 30dc697 May 1, 2024
19 checks passed
@vikiival
Copy link
Member

vikiival commented May 1, 2024

Thanks @dudo50

This was referenced May 2, 2024
@prury prury mentioned this pull request May 7, 2024
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants