Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farcaster auth #10195

Merged
merged 21 commits into from
May 6, 2024
Merged

Farcaster auth #10195

merged 21 commits into from
May 6, 2024

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 2, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copy link

socket-security bot commented May 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@farcaster/auth-client@0.1.1 network 0 105 kB daddeo

🚮 Removed packages: npm/consola@3.2.3

View full report↗︎

Copy link

netlify bot commented May 2, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 090f256
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6639229891914f000802ce90
😎 Deploy Preview https://deploy-preview-10195--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daiagi daiagi marked this pull request as ready for review May 3, 2024 06:24
@daiagi daiagi requested a review from a team as a code owner May 3, 2024 06:24
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team May 3, 2024 06:24
@JustLuuuu
Copy link
Member

JustLuuuu commented May 3, 2024

Tried FC data download. I signed the message in the FC app. I think it was successful, but nothing happened on Koda. This is browser after signing:

Screen.Recording.2024-05-03.at.12.19.30.mov

@vikiival
Copy link
Member

vikiival commented May 3, 2024

Sir please have you tested?

  1. Login modal will never close (prob bug of that modal?)

I am stuck here

Screenshot 2024-05-03 at 12 19 00

I need to supply both image and banner on my onw

Screenshot 2024-05-03 at 12 19 21

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per test

@daiagi
Copy link
Contributor Author

daiagi commented May 3, 2024

Sir please have you tested?

yes. i did
now will test some more 😄

@daiagi
Copy link
Contributor Author

daiagi commented May 3, 2024

@JustLuuuu

you are supposed to scan the QR and the log in via phone

@daiagi
Copy link
Contributor Author

daiagi commented May 3, 2024

@vikiival

small yet critical bug

fixed

image

@daiagi daiagi requested a review from vikiival May 3, 2024 12:11
@daiagi
Copy link
Contributor Author

daiagi commented May 3, 2024

one thing

even importing farcaster profile Still Have to upload banner picture

do we want to change that @vikiival @JustLuuuu ?

farcaster + upload banner :
https://deploy-preview-10195--koda-canary.netlify.app/ahp/u/13QX2TXxxRHMrM1CdosnRkpQKTvvdsRFAdpn57jRhAYykJmj

@vikiival
Copy link
Member

vikiival commented May 3, 2024

cc @exezbcz

I would make banner optional for now :)

@vikiival
Copy link
Member

vikiival commented May 3, 2024

you are supposed to scan the QR and the log in via phone

Screenshot 2024-05-03 at 15 21 02

@exezbcz
Copy link
Member

exezbcz commented May 3, 2024

I would make banner optional for now :)

it is, if you don't fill it out, it just defaults to the grey.

we can put the small text there

@prury
Copy link
Member

prury commented May 3, 2024

this qr code that warpcast provides is unreadable for me haha, had to send the whole link via telegram and access it from mobile, then it worked, not our problem i know.

regarding the whole functionality, agree with banner being optional
and will open another issue for for fields being optional or not.

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 3, 2024
@vikiival
Copy link
Member

vikiival commented May 6, 2024

If you remove desc the App will crash

Screenshot 2024-05-06 at 12 17 46

@vikiival
Copy link
Member

vikiival commented May 6, 2024

Description is using different component that collection description (a.k.a MD does not work)

Screenshot 2024-05-06 at 12 20 11

Edit does not work.

@vikiival
Copy link
Member

vikiival commented May 6, 2024

But auth works, others can be done in the follow-up

@daiagi daiagi requested a review from vikiival May 6, 2024 13:59
@daiagi
Copy link
Contributor Author

daiagi commented May 6, 2024

If you remove desc the App will crash

fixed, by disabling the submit button in edit mode if any required field is missing (name, description, profile pic)

But auth works, others can be done in the follow-up

if so, approve PR please

Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit 090f256 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels May 6, 2024
@prury prury enabled auto-merge May 6, 2024 20:19
@prury prury added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit b98b5b9 May 6, 2024
19 checks passed
@prury prury deleted the farcaster-auth branch May 6, 2024 20:21
@prury prury mentioned this pull request May 7, 2024
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate farcaster into ProfileV3
6 participants