-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Farcaster auth #10195
Farcaster auth #10195
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/consola@3.2.3 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Tried FC data download. I signed the message in the FC app. I think it was successful, but nothing happened on Koda. This is browser after signing: Screen.Recording.2024-05-03.at.12.19.30.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per test
yes. i did |
you are supposed to scan the QR and the log in via phone |
small yet critical bug fixed |
one thing even importing farcaster profile Still Have to upload banner picture do we want to change that @vikiival @JustLuuuu ? farcaster + upload banner : |
cc @exezbcz I would make banner optional for now :) |
it is, if you don't fill it out, it just defaults to the grey. we can put the small text there |
this qr code that warpcast provides is unreadable for me haha, had to send the whole link via telegram and access it from mobile, then it worked, not our problem i know. regarding the whole functionality, agree with banner being optional |
fix: Button size in create new profile
But auth works, others can be done in the follow-up |
fixed, by disabling the submit button in edit mode if any required field is missing (name, description, profile pic)
if so, approve PR please |
Code Climate has analyzed commit 090f256 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸