Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Followers UX improvements #10196

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: Followers UX improvements #10196

merged 1 commit into from
May 6, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 2, 2024 22:05
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team May 2, 2024 22:05
Copy link

netlify bot commented May 2, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3d1f5a4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66340e49c1e1080008853da8
😎 Deploy Preview https://deploy-preview-10196--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented May 2, 2024

Code Climate has analyzed commit 3d1f5a4 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented May 3, 2024

it works, but will let Exez check this one

@prury prury requested a review from exezbcz May 3, 2024 14:57
@Jarsen136
Copy link
Contributor Author

@exezbcz May I get your review? 👀

@exezbcz
Copy link
Member

exezbcz commented May 6, 2024

of course, the hover looks good, nice addition.

How can i test the hover over the profiles? Could you please send me profile that i can start following?

@prury
Copy link
Member

prury commented May 6, 2024

of course, the hover looks good, nice addition.

How can i test the hover over the profiles? Could you please send me profile that i can start following?

https://deploy-preview-10196--koda-canary.netlify.app/ahp/u/1CBmjqJvV1ha8BPQ5JAXGEzeJBLmGHNG9gYg96eC1dnjH5W

@exezbcz
Copy link
Member

exezbcz commented May 6, 2024

yup, its good!

@prury prury added this pull request to the merge queue May 6, 2024
Merged via the queue into kodadot:main with commit 8f0bfcb May 6, 2024
19 checks passed
@prury prury mentioned this pull request May 7, 2024
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followers UX improvements
5 participants