Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make possible it possible not to be necessary to enter all fields on Profile & handler profile error #10206

Merged
merged 2 commits into from
May 4, 2024
Merged

Make possible it possible not to be necessary to enter all fields on Profile & handler profile error #10206

merged 2 commits into from
May 4, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 3, 2024 •
edited

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 3, 2024 22:02
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team May 3, 2024 22:02
@Jarsen136 Jarsen136 changed the title Issue 10204 Make possible it possible not to be necessary to enter all fields on Profile & handler profile error May 3, 2024
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c47861f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66355ef977f03b0008606549
😎 Deploy Preview https://deploy-preview-10206--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 3, 2024

Code Climate has analyzed commit c47861f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jarsen136 Jarsen136 requested a review from daiagi May 3, 2024 22:04
@daiagi
Copy link
Contributor

daiagi commented May 4, 2024

@prury Merging

@daiagi daiagi added this pull request to the merge queue May 4, 2024
Merged via the queue into kodadot:main with commit fde030d May 4, 2024
18 of 19 checks passed
@prury prury mentioned this pull request May 7, 2024
Merged
This was referenced May 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@daiagi daiagi daiagi approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle profile BE error Make possible it possible not to be necessary to enter all fields on Profile
4 participants
@Jarsen136 @daiagi @preschian @hassnian