Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Loaders and skeletons for new profile #10232

Merged
merged 2 commits into from
May 6, 2024
Merged

fix: Loaders and skeletons for new profile #10232

merged 2 commits into from
May 6, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Kapture

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 5, 2024 15:22
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team May 5, 2024 15:22
@netlify Netlify
Copy link

netlify bot commented May 5, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2bb1e46
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6638e115b9d903000934e3bb
😎 Deploy Preview https://deploy-preview-10232--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

daiagi
daiagi approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

The wrapping div seems to uneeded

Other that that let's roll

@Jarsen136
Copy link
Contributor Author

Nitpick

The wrapping div seems to uneeded

Other that that let's roll

It's because we could not put v-if and v-for on the same element.
ref: https://vuejs.org/guide/essentials/conditional.html#v-if-with-v-for

@prury
Copy link
Member

prury commented May 6, 2024

here for me they are too close to each other:

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 6, 2024
@Jarsen136
Copy link
Contributor Author

here for me they are too close to each other:

image

✅ Fixed

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit 2bb1e46 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels May 6, 2024
@prury prury added this pull request to the merge queue May 6, 2024
Merged via the queue into kodadot:main with commit f389a77 May 6, 2024
19 checks passed
@prury prury mentioned this pull request May 7, 2024
Merged
This was referenced May 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loaders and skeletons for new profile
4 participants
@Jarsen136 @prury @daiagi @hassnian