feat: Enable links in bio

[hassnian]

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Enable links in bio  #10237

Needs QA check

• @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

• Fill up your DOT address: Payout

Screenshot 📸

• My fix has changed something on UI;

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	a5869e6
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/66729a90707cdc0008a43d8f
😎 Deploy Preview	https://deploy-preview-10337--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[prury]

can we make it not affect markdown tags?

[hassnian]

can we make it not affect markdown tags?

pls try again

[vikiival]

TL;DR

parsing desc and checking for /channle (eg. /koda) or @user (e.g @vikiival)

cc @exezbcz I think it should be done on the create profile level, it would break markdown links imo

[vikiival]

as pointed in comment above

cc @daiagi

[exezbcz]

@vikiival how?

[vikiival]

@vikiival how?

This PR

https://deploy-preview-10337--koda-canary.netlify.app/ahp/u/14BZFbYEGoWWPjbbZUdLZ1TqDtdXvdeCy3R3t4QXqJmS91Dx

Prod:

[vikiival]

TL;DR of your changes?

[prury]

TL;DR of your changes?

Links are now added on profile save

@prury can you test again, this should be fixed , thanks

seems good now

[vikiival]

[vikiival]

Works as intented.
But I have a problem:

I use create profile (manual), inserted fan of /koda it was automatically translated to warpcast link.

My question is: Should it be enabled only in case when you use import from farcaster ?

cc @exezbcz

[vikiival]

also thinking why you do not translate it to markdown links? rather than html?

<a href="https://warpcast.com/~/channel/koda" target="_blank" rel="nofollow noopener noreferrer">/koda</a>

vs

[/koda](https://warpcast.com/~/channel/koda)

[exezbcz]

My question is: Should it be enabled only in case when you use import from farcaster ?

/koda should be translated only when importing from farcaster

as /koda can mean something else on koda itself in the future

[vikiival]

as per exez's comment above

[hassnian]

also thinking why you do not translate it to markdown links? rather than html?

@vikiival so they open in a new tab , can change it if it's not important.

[hassnian]

My question is: Should it be enabled only in case when you use import from farcaster ?

/koda should be translated only when importing from farcaster

as /koda can mean something else on koda itself in the future

fixed

[vikiival]

also thinking why you do not translate it to markdown links? rather than html?

@vikiival so they open in a new tab , can change it if it's not important.

Every link on profiles are markdown based. I prefer to have it unified

[hassnian]

Every link on profiles are markdown based. I prefer to have it unified

done

[sonarcloud]

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

[prury]

@hassnian can you check profile creation trough farcaster using this PR? i tried testing here and it won't work
on canary it goes normally.

[codeclimate]

Code Climate has analyzed commit a5869e6 and detected 0 issues on this pull request.

View more on Code Climate.

[vikiival]

@hassnian can you check profile creation trough farcaster using this PR? i tried testing here and it won't work on canary it goes normally.

cc @hassnian

[hassnian]

@hassnian can you check profile creation trough farcaster using this PR? i tried testing here and it won't work on canary it goes normally.

using new worker: same issues as #10485 (comment)
using older version of the worker: works fine ✅

CleanShot.2024-06-19.at.14.07.24.mp4