Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Activity table does not work on Base #10387

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

There are still two issues related to the indexer side for Base. @vikiival

  1. incorrect price amount
  2. missing from/to address
    image

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 3, 2024 20:24
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team June 3, 2024 20:24
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 68ae683
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/665e2667517e610008bba61c
😎 Deploy Preview https://deploy-preview-10387--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Jun 3, 2024

Code Climate has analyzed commit 68ae683 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival
Copy link
Member

vikiival commented Jun 4, 2024

Thanks @Jarsen136 issue is on the indexer side.
Will deploy a new version.

AHP

Screenshot 2024-06-04 at 12 23 37

Base

Screenshot 2024-06-04 at 12 24 36

Notes

incorrect price amount

Mint does not have price

Mint (from) is always address(0)

https://opensea.io/assets/ethereum/0x1352149cd78d686043b504e7e7d96c5946b0c39c/1937

Screenshot 2024-06-04 at 12 19 00

@vikiival
Copy link
Member

vikiival commented Jun 4, 2024

I have released a new version of

@vikiival vikiival mentioned this pull request Jun 4, 2024
8 tasks
@prury
Copy link
Member

prury commented Jun 4, 2024

Mint does not have price

@vikiival

for some, mint has price:

image
https://opensea.io/assets/base/0xc029b380f8a451cfd9e5124fa9fcad4397b8c119/10

@prury
Copy link
Member

prury commented Jun 4, 2024

let me know if we are merging it in its current state (unreal minting price)

@Jarsen136
Copy link
Contributor Author

let me know if we are merging it in its current state (unreal minting price)

It should be fixed after the indexer is deployed. @vikiival How can we check the deploy status?

@vikiival
Copy link
Member

vikiival commented Jun 5, 2024

It should be fixed after the indexer is deployed. @vikiival How can we check the deploy status?

https://app.subsquid.io/

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as a charm

@vikiival vikiival added this pull request to the merge queue Jun 5, 2024
Merged via the queue into kodadot:main with commit eafc524 Jun 5, 2024
19 checks passed
@vikiival vikiival mentioned this pull request Jun 12, 2024
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity table does not work on Base
4 participants