Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-checker): Problematic art passing #10413

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jun 6, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

failed

CleanShot 2024-06-06 at 11 31 42@2x

passed

CleanShot 2024-06-06 at 11 33 26@2x

@hassnian hassnian requested a review from a team as a code owner June 6, 2024 06:35
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team June 6, 2024 06:35
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9459742
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/666158bc204cd5000805ff28
😎 Deploy Preview https://deploy-preview-10413--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title fix: Code-checker: Problematic art passing fix(code-checker): Problematic art passing Jun 6, 2024
Copy link

codeclimate bot commented Jun 6, 2024

Code Climate has analyzed commit 9459742 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Jun 10, 2024

tested several arts and also the art that was calling kodahash many times, seems good to go

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 10, 2024
@prury prury added this pull request to the merge queue Jun 11, 2024
Merged via the queue into kodadot:main with commit 7dc40b8 Jun 11, 2024
19 checks passed
@prury prury deleted the issue-10367 branch June 11, 2024 11:02
@vikiival vikiival mentioned this pull request Jun 12, 2024
This was referenced Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code-checker: Problematic art passing
4 participants