Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attach fall through attributes to teleport component #10585

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

AnmolBansalDEV
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Needs QA check

  • @kodadot/qa-guild please review

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@AnmolBansalDEV AnmolBansalDEV requested a review from a team as a code owner July 4, 2024 19:14
@AnmolBansalDEV AnmolBansalDEV requested review from preschian and Jarsen136 and removed request for a team July 4, 2024 19:14
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 886733b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/668ba134bbb99f000825c6db
😎 Deploy Preview https://deploy-preview-10585--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

vikiival commented Jul 8, 2024

@Jarsen136 review pls

Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit 886733b and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival added this pull request to the merge queue Jul 8, 2024
Merged via the queue into kodadot:main with commit b1b132f Jul 8, 2024
19 checks passed
@AnmolBansalDEV
Copy link
Contributor Author

@vikiival what are the next steps for claiming the bounty? Thanks!

@AnmolBansalDEV AnmolBansalDEV deleted the fix/neomodal-warning branch July 8, 2024 10:08
@vikiival
Copy link
Member

vikiival commented Jul 8, 2024

pay 10 usd

@AnmolBansalDEV
Copy link
Contributor Author

Thank you @vikiival ! This is my first bounty. I hope to contribute more to the project 😄

@vikiival vikiival added the paid pull-request has been paid label Jul 14, 2024
@kodadot kodadot locked as resolved and limited conversation to collaborators Jul 14, 2024
@vikiival
Copy link
Member

😍 Perfect, I’ve sent the payout
💵 $10 @ 6.19 USD/DOT ~ 1.616 $DOT
🧗 12b5bwwugf3CgWy58MPYQAX9wazLX1S71ghgZ4YPb6g4qbEP
🔗 0x99d28db3f8e396dd4252f1f7eeed2be096c3a65318f688a058514542dec2c06b
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoModal class props warning
4 participants