feat(collections): filters #1292
Conversation
| @@ -137,8 +158,11 @@ export default class Collections extends Vue { | |||
| result: this.handleResult, | |||
| variables: () => { | |||
| return { | |||
| orderBy: this.searchQuery.sortBy, | |||
| search: this.buildSearchParam(), | |||
| listed: this.searchQuery.listed ? [{price: { greaterThan: '0'}}] : [], | |||
There was a problem hiding this comment.
this filters only those with price -> metrics can be skewed
Maybe @vikiival would have idea? would be amazing to close on this, collections are not great with empty collections so not wasting collectors attention, showing only those which can get would be interesting. Like by default I would put something, show only collections where is at least 1 NFT for BUY |
| @@ -137,8 +158,11 @@ export default class Collections extends Vue { | |||
| result: this.handleResult, | |||
| variables: () => { | |||
| return { | |||
| orderBy: this.searchQuery.sortBy, | |||
| search: this.buildSearchParam(), | |||
| listed: this.searchQuery.listed ? [{price: { greaterThan: '0'}}] : [], | |||
There was a problem hiding this comment.
this filters only those with price -> metrics can be skewed
you can't filter on the nested entity input CollectionEntityFilter {
version: StringFilter
name: StringFilter
max: IntFilter
issuer: StringFilter
symbol: StringFilter
id: StringFilter
metadata: StringFilter
currentOwner: StringFilter
events: JSONFilter
blockNumber: BigFloatFilter
createdAt: DatetimeFilter
updatedAt: DatetimeFilter
and: [CollectionEntityFilter!]
or: [CollectionEntityFilter!]
not: CollectionEntityFilter
}the possible hack is to count already minted NFTs in the collection entity
It will skew the metrics
|
We got the totalCount of nfts in collection but can't query/filter on > 0.
Buy now toggle will change metrics for sure. (as it filter nfts price > 0 in collection) |
Have you tried to run it on your local machine? 💻 |
Which metrics? Items? |
|
Just chatted w @vikiival let's remove empty collection on UI till we figure out other solutions, just to have this working 😄 Lets do hacky solution for now, same with BUY stuff |
|
Bump, can we remove empty collections on UI and let's merge this @roiLeo ?
|
hotfix would be to remove card from row and it's not looking great I'm sure something can be done with graphql |
|
Yeah, but looking for empty collections is draining attention is worse than showing nothing 😄 Let's push it and we will "upgrade" it later, even now it's a huge step with functionality tho! |
|
WFM continue to #1357 |
I didn't find a way to remove empty collections from query yet
PR type
Before submitting Pull Request, please make sure:
What's new?
Screenshot