Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚒️ route & i18n compiled route #1471

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 9, 2021

Tous les chemins mènent à Rome

Now I understand why @dezine2dev rewrote all the routes.
Nuxt i18n had bad configuration.

Should we keep /gallery/{id} ?

PR type

  • Bugfix

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality

What's new?

no more missing path

@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: a20dcb4

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61b37191bcfee000083bd891

😎 Browse the preview: https://deploy-preview-1471--koda-nuxt.netlify.app

@roiLeo roiLeo marked this pull request as draft December 9, 2021 15:47
@roiLeo roiLeo marked this pull request as ready for review December 9, 2021 15:52
@vikiival
Copy link
Member

vikiival commented Dec 9, 2021

Should we keep /gallery/{id} ?

yup there are many kodadot links in the wild

@yangwao
Copy link
Member

yangwao commented Dec 10, 2021

Should we keep /gallery/{id} ?

yup there are many kodadot links in the wild

It's should be /detail/{id}

@roiLeo roiLeo marked this pull request as draft December 10, 2021 15:24
@roiLeo roiLeo marked this pull request as ready for review December 10, 2021 15:27
@roiLeo roiLeo added the A-nuxt label Dec 10, 2021
@yangwao
Copy link
Member

yangwao commented Dec 10, 2021

but the old route should be gone or not? :D

Screen.Recording.2021-12-10.at.16.50.04.mov

@yangwao yangwao merged commit e156d56 into kodadot:main-nuxt Dec 10, 2021
@roiLeo roiLeo deleted the fix/route branch December 10, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants