Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circumvent opengraph namespace caching #1799

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
馃憞 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes seo revisit 聽#1790
  • Let's see if this works. according to https://ogp.me/#type_website fb will only consider image of root page when og:type is same on all the subpages. I therefore changed them to profile or article which doesn't 100% reflect content but as you can see there aren't that many types available and these seem to be the closest

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main-nuxt and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 13, 2022

鉁旓笍 Deploy Preview for koda-nuxt ready!

馃敤 Explore the source changes: c948c76

馃攳 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61dfc7fbbde3a700083386ba

馃槑 Browse the preview: https://deploy-preview-1799--koda-nuxt.netlify.app

@kkukelka
Copy link
Member Author

Source

OG:TYPE effects your image scrape:

https://ogp.me/#type_article not the same as https://ogp.me/#type_website
Be aware that og:type=website will cause any /sub-pages/ of that url to become "canonical". This means you will have trouble getting your images to update using the scraper no matter what you do.

Consider this "assumption and common mistake"

- => https://www.example.org (parent)
- => https://www.example.org/sub-page/
- => https://www.example.org/sub-page/child-2/

  • Ergo: /sub-page/ and /child-2/ will inherit the og:image of the parent

Those are not "all websites", 1 is a website, the others are articles.

If you do that Facebook will think all of those are canonical and it will put the FIRST og:image into all of them. (try it, you'll see) - if you set the og:url to be your root or parent domain you've told facebook they are all canonical. (there is good reason for that, but its off topic)

@yangwao
Copy link
Member

yangwao commented Jan 13, 2022

okay let's try!

@yangwao yangwao merged commit 3ea5439 into kodadot:main-nuxt Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seo revisit
2 participants