Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Last" bugs for Statemine #2158

Merged
merged 22 commits into from
Feb 2, 2022
Merged

"Last" bugs for Statemine #2158

merged 22 commits into from
Feb 2, 2022

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Feb 1, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival self-assigned this Feb 1, 2022
@vikiival vikiival requested a review from yangwao February 1, 2022 14:04
@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: bece9c2

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61fa6f647199ed000727ed83

😎 Browse the preview: https://deploy-preview-2158--koda-nuxt.netlify.app

@vikiival vikiival linked an issue Feb 1, 2022 that may be closed by this pull request
12 tasks
…ine-article

# Conflicts:
#	components/rmrk/Gallery/Gallery.vue
#	components/rmrk/Gallery/GalleryItem.vue
@yangwao yangwao merged commit 79381e0 into main Feb 2, 2022
@yangwao yangwao deleted the wao-is-reading-statemine-article branch February 2, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants