Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HyperCSS Wao #2240

Merged
merged 3 commits into from
Feb 5, 2022
Merged

HyperCSS Wao #2240

merged 3 commits into from
Feb 5, 2022

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Feb 5, 2022

  • 🐛 default height on description wrapper was incorrect
  • ⚡ refactored appreciation
  • 🧑‍💻 added types to the pagination
  • 💄 can now directly send heart from main screen
  • 🧑‍💻 Appreciation is using minimark
  • 🐛 pagination err on latest sales
  • 🐛 appreciation is going away
  • 🎨 terrible css fix
  • 🎨 two plus one free
  • 🔧 prettier semiqoute true

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Feb 5, 2022 •
edited

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: a3e5f72

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61fe9ffd8a748a0008f45ff1

😎 Browse the preview: https://deploy-preview-2240--koda-nuxt.netlify.app

@yangwao yangwao merged commit 7950706 into hyper-jpeg Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vikiival @yangwao