Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2344 Rework navbar #2348

Merged
merged 5 commits into from
Feb 14, 2022
Merged

#2344 Rework navbar #2348

merged 5 commits into from
Feb 14, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Feb 14, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2022-02-14 at 1 22 51 PM

@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: f7aa02d

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/620a46dcffd4950008e43dcc

😎 Browse the preview: https://deploy-preview-2348--koda-nuxt.netlify.app

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, I would keep language switcher next to login button like this:
Screenshot 2022-02-14 at 11-56-02 KodaDot - Kusama NFT Market Explorer

When on another chain some of the menu should be hidden (Stats?)
Screenshot 2022-02-14 at 11-59-49 KodaDot - Kusama NFT Market Explorer

@prachi00
Copy link
Member Author

@roiLeo doneee

@yangwao
Copy link
Member

yangwao commented Feb 14, 2022

Doesn't take me anywhere :|

Screen.Recording.2022-02-14.at.12.49.00.mov

@prachi00
Copy link
Member Author

Doesn't take me anywhere :|

Screen.Recording.2022-02-14.at.12.49.00.mov

found the issue, fixing it

@prachi00
Copy link
Member Author

@yangwao check now

@yangwao
Copy link
Member

yangwao commented Feb 14, 2022

love you! 😘

pay 200 usd

@yangwao yangwao merged commit 8f196bf into kodadot:main Feb 14, 2022
@yangwao
Copy link
Member

yangwao commented Feb 14, 2022

😍 Perfect, I’ve sent the payout
💵 $200 @ 161.6 USD/KSM ~ 1.238 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x0f683cefd64ee30ab53b073df12d9707b4c7ba07fb225984257d00d9c993d093

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework navbar a bit
3 participants